All users were logged out of Bugzilla on October 13th, 2018

Change sidebar default behavior to slide the browser chrome partially offscreen

RESOLVED FIXED in Firefox 23

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: lucasr, Assigned: lucasr)

Tracking

unspecified
Firefox 23
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
As per discussion with ibarlow on IRC, we'll go ahead and change the default behavior of sidebar to slide the browser chrome partially offscreen. The option for pinning the sidebar can be added in bug 817728.
(Assignee)

Updated

6 years ago
Blocks: 860121
(Assignee)

Comment 1

6 years ago
Created attachment 744593 [details] [diff] [review]
/860121 - New Fennec sidebar animation
Attachment #744593 - Flags: review?(mark.finkle)
Comment on attachment 744593 [details] [diff] [review]
/860121 - New Fennec sidebar animation


>diff --git a/mobile/android/base/BrowserApp.java b/mobile/android/base/BrowserApp.java

>     public void onTabsLayoutChange(int width, int height) {

>+        final boolean areTabsShown = areTabsShown();
>+        if (areTabsShown) {
>             mTabsPanel.setDescendantFocusability(ViewGroup.FOCUS_AFTER_DESCENDANTS);

Do you need the local (final) areTabsShown?
Attachment #744593 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 3

6 years ago
(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 744593 [details] [diff] [review]
> /860121 - New Fennec sidebar animation
> 
> 
> >diff --git a/mobile/android/base/BrowserApp.java b/mobile/android/base/BrowserApp.java
> 
> >     public void onTabsLayoutChange(int width, int height) {
> 
> >+        final boolean areTabsShown = areTabsShown();
> >+        if (areTabsShown) {
> >             mTabsPanel.setDescendantFocusability(ViewGroup.FOCUS_AFTER_DESCENDANTS);
> 
> Do you need the local (final) areTabsShown?

Leftover from a previous version of the patch. Removed.
https://hg.mozilla.org/mozilla-central/rev/e6c09bae2a13
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
You need to log in before you can comment on or make changes to this bug.