Closed
Bug 867600
Opened 9 years ago
Closed 9 years ago
Change hardcoded sleeps into webdriver waits
Categories
(Testing :: Marionette, defect)
Testing
Marionette
Tracking
(firefox27 fixed, firefox28 fixed, firefox29 fixed, b2g-v1.3 fixed, b2g-v1.4 fixed)
RESOLVED
FIXED
mozilla29
People
(Reporter: mdas, Assigned: davehunt)
References
Details
Attachments
(1 file, 1 obsolete file)
6.51 KB,
patch
|
davehunt
:
review+
|
Details | Diff | Splinter Review |
Once Bug 850881 lands, we should change our hardcoded sleeps in our tests (usually ones with gestures), to using a proper wait until clause.
Assignee | ||
Comment 1•9 years ago
|
||
Try run: https://tbpl.mozilla.org/?tree=Try&rev=819cf1208f37
Assignee: nobody → dave.hunt
Status: NEW → ASSIGNED
Attachment #8349329 -
Flags: review?(mdas)
Attachment #8349329 -
Flags: feedback?(ato)
Comment 2•9 years ago
|
||
Comment on attachment 8349329 [details] [diff] [review] Change hardcoded sleeps into waits. v1.0 Review of attachment 8349329 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8349329 -
Flags: feedback?(ato)
Reporter | ||
Updated•9 years ago
|
Attachment #8349329 -
Flags: review?(mdas) → review+
Assignee | ||
Comment 3•9 years ago
|
||
I just noticed that by doing this I've reduced two of the waits from ~30 seconds to 5. I'm going to assume there was a good reason for them to be longer, so I'll upload a new patch shortly. I'll carry the r+ unless anyone interjects.
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8349329 -
Attachment is obsolete: true
Attachment #8349499 -
Flags: review+
Reporter | ||
Comment 5•9 years ago
|
||
landed in m-i: https://hg.mozilla.org/integration/mozilla-inbound/rev/23b96cc7f73b
Comment 6•9 years ago
|
||
Comment 5's cset was empty, but it looks like davehunt pushed a non-empty version of this patch right after: https://hg.mozilla.org/integration/mozilla-inbound/rev/e1810ea3ee51
Assignee | ||
Comment 7•9 years ago
|
||
I wasn't able to land this on inbound due to tree closure. Once it was open I pushed without checking if it had already been landed, sorry. https://hg.mozilla.org/integration/mozilla-inbound/rev/5bfe133fd363
Assignee | ||
Comment 8•9 years ago
|
||
Bah, and then I linked to the wrong revision. Sorry again. https://hg.mozilla.org/integration/mozilla-inbound/rev/e1810ea3ee51
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/23b96cc7f73b https://hg.mozilla.org/mozilla-central/rev/e1810ea3ee51
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Comment 10•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/d77cab4ae8a6 https://hg.mozilla.org/releases/mozilla-beta/rev/558c0e6beada https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/99550870b1f5
status-b2g-v1.2:
--- → fixed
status-b2g-v1.3:
--- → fixed
status-b2g-v1.4:
--- → fixed
status-firefox27:
--- → fixed
status-firefox28:
--- → fixed
status-firefox29:
--- → fixed
Comment 11•9 years ago
|
||
I pressed my luck a bit too much on this. Backed out from b2g26 for test failures that I've already gone too far down the rabbit hole trying to fix. https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/b01ca2847626
status-b2g-v1.2:
fixed → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•