867600 - Change hardcoded sleeps into webdriver waits

Status: RESOLVED FIXED

(Testing :: Marionette, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

Once Bug 850881 lands, we should change our hardcoded sleeps in our tests (usually ones with gestures), to using a proper wait until clause.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚GMT]

Attachment: Change hardcoded sleeps into waits. v1.0

Try run: https://tbpl.mozilla.org/?tree=Try&rev=819cf1208f37

Comment 2

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8349329 [details] [diff] [review]
Change hardcoded sleeps into waits. v1.0

Review of attachment 8349329 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚GMT]

I just noticed that by doing this I've reduced two of the waits from ~30 seconds to 5. I'm going to assume there was a good reason for them to be longer, so I'll upload a new patch shortly. I'll carry the r+ unless anyone interjects.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚GMT]

Attachment: Change hardcoded sleeps into waits. v1.1

Comment 5

[Malini Das [:mdas] - Away, not checking bugmail]

landed in m-i:
https://hg.mozilla.org/integration/mozilla-inbound/rev/23b96cc7f73b

Comment 6

[Daniel Holbert [:dholbert]]

Comment 5's cset was empty, but it looks like davehunt pushed a non-empty version of this patch right after:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/e1810ea3ee51

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚GMT]

I wasn't able to land this on inbound due to tree closure. Once it was open I pushed without checking if it had already been landed, sorry.

https://hg.mozilla.org/integration/mozilla-inbound/rev/5bfe133fd363

Comment 8

[Dave Hunt [:davehunt] [he/him] ⌚GMT]

Bah, and then I linked to the wrong revision. Sorry again.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1810ea3ee51

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/23b96cc7f73b
https://hg.mozilla.org/mozilla-central/rev/e1810ea3ee51

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d77cab4ae8a6
https://hg.mozilla.org/releases/mozilla-beta/rev/558c0e6beada
https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/99550870b1f5

Comment 11

[Ryan VanderMeulen [:RyanVM]]

I pressed my luck a bit too much on this. Backed out from b2g26 for test failures that I've already gone too far down the rabbit hole trying to fix.

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/b01ca2847626