Closed Bug 867600 Opened 8 years ago Closed 8 years ago

Change hardcoded sleeps into webdriver waits

Categories

(Testing :: Marionette, defect)

defect
Not set
normal

Tracking

(firefox27 fixed, firefox28 fixed, firefox29 fixed, b2g-v1.3 fixed, b2g-v1.4 fixed)

RESOLVED FIXED
mozilla29
Tracking Status
firefox27 --- fixed
firefox28 --- fixed
firefox29 --- fixed
b2g-v1.3 --- fixed
b2g-v1.4 --- fixed

People

(Reporter: mdas, Assigned: davehunt)

References

Details

Attachments

(1 file, 1 obsolete file)

Once Bug 850881 lands, we should change our hardcoded sleeps in our tests (usually ones with gestures), to using a proper wait until clause.
Try run: https://tbpl.mozilla.org/?tree=Try&rev=819cf1208f37
Assignee: nobody → dave.hunt
Status: NEW → ASSIGNED
Attachment #8349329 - Flags: review?(mdas)
Attachment #8349329 - Flags: feedback?(ato)
Comment on attachment 8349329 [details] [diff] [review]
Change hardcoded sleeps into waits. v1.0

Review of attachment 8349329 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8349329 - Flags: feedback?(ato)
Attachment #8349329 - Flags: review?(mdas) → review+
I just noticed that by doing this I've reduced two of the waits from ~30 seconds to 5. I'm going to assume there was a good reason for them to be longer, so I'll upload a new patch shortly. I'll carry the r+ unless anyone interjects.
Attachment #8349329 - Attachment is obsolete: true
Attachment #8349499 - Flags: review+
Comment 5's cset was empty, but it looks like davehunt pushed a non-empty version of this patch right after:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/e1810ea3ee51
I wasn't able to land this on inbound due to tree closure. Once it was open I pushed without checking if it had already been landed, sorry.

https://hg.mozilla.org/integration/mozilla-inbound/rev/5bfe133fd363
Bah, and then I linked to the wrong revision. Sorry again.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1810ea3ee51
https://hg.mozilla.org/mozilla-central/rev/23b96cc7f73b
https://hg.mozilla.org/mozilla-central/rev/e1810ea3ee51
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
I pressed my luck a bit too much on this. Backed out from b2g26 for test failures that I've already gone too far down the rabbit hole trying to fix.

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/b01ca2847626
You need to log in before you can comment on or make changes to this bug.