Closed Bug 867685 Opened 8 years ago Closed 8 years ago

GeckoLayerClient.setIsRTL doesn't hold the lock while reading/writing the viewport metrics

Categories

(Firefox for Android Graveyard :: Toolbar, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 23

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(2 files)

No description provided.
Attachment #744214 - Flags: review?(chrislord.net)
Attached patch Part 2 - fixSplinter Review
Attachment #744215 - Flags: review?(chrislord.net)
Comment on attachment 744214 [details] [diff] [review]
Part 1 - cleanup for clarity

Review of attachment 744214 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #744214 - Flags: review?(chrislord.net) → review+
Comment on attachment 744215 [details] [diff] [review]
Part 2 - fix

Review of attachment 744215 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for catching this :)
Attachment #744215 - Flags: review?(chrislord.net) → review+
https://hg.mozilla.org/mozilla-central/rev/076a7fd863a5
https://hg.mozilla.org/mozilla-central/rev/2eb479391111
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.