GeckoLayerClient.setIsRTL doesn't hold the lock while reading/writing the viewport metrics

RESOLVED FIXED in Firefox 23

Status

()

Firefox for Android
Toolbar
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

unspecified
Firefox 23
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Created attachment 744214 [details] [diff] [review]
Part 1 - cleanup for clarity
Attachment #744214 - Flags: review?(chrislord.net)
Created attachment 744215 [details] [diff] [review]
Part 2 - fix
Attachment #744215 - Flags: review?(chrislord.net)

Comment 2

5 years ago
Comment on attachment 744214 [details] [diff] [review]
Part 1 - cleanup for clarity

Review of attachment 744214 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #744214 - Flags: review?(chrislord.net) → review+

Comment 3

5 years ago
Comment on attachment 744215 [details] [diff] [review]
Part 2 - fix

Review of attachment 744215 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for catching this :)
Attachment #744215 - Flags: review?(chrislord.net) → review+
https://hg.mozilla.org/mozilla-central/rev/076a7fd863a5
https://hg.mozilla.org/mozilla-central/rev/2eb479391111
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
You need to log in before you can comment on or make changes to this bug.