867710 - MakeAPI should never display deleted makes

Status: RESOLVED FIXED

(Webmaker Graveyard :: MakeAPI, defect)

Description

[Chris DeCairos (:cade)]

The Make API doesn't actually delete records, it marks them with a deletedAt timestamp.

I just realized that the search API will return deleted makes.

The server can add in a filter on all searches to ensures deleted Makes do not show in results.

Comment 1

[Chris DeCairos (:cade)]

Although, Admins might want to override that... hmm.

Comment 2

[David Ascher (:davida)]

Note: we should likely actually delete makes, assuming the UI for users is actually "delete".  There are possible privacy issues otherwise, and we may some day be legally bound to do such deletions.

(AKA: Why does the make API not actually delete records?)

Comment 3

[Chris DeCairos (:cade)]

When I started on the code base, it's how it was originally set up.

Not sure why the decision was originally made to soft-delete records, but it's an easy fix to permanently remove them.

Comment 4

[Chris DeCairos (:cade)]

:wex - what are your thoughts on moving to an actual delete of make records?

Comment 5

[Simon C. Wex]

David is right from a data retention perspective. I hate not having the ability to undo a delete though.

:davida, if we did a hard delete for all Makes deleted over X days ago, would that satisfy your assertion?

Comment 6

[David Ascher (:davida)]

Sure -- alternatively, have "Move to trash" and "Empty trash".

Comment 7

[Simon C. Wex]

:cade I like a combination of these ^.

I don't think this is a requirement for June, but could you create (a) bug(s) for that feature?

 - hard delete everything that was deleted 14 days earlier (daily task)
 - make sure that you can update a make's deletedAt field to null (this is how we do undo delete)
 - make sure those with permission (creator of make & admins) can view deleted makes
 - figure out how to hard delete through the API

The admin UI and webmaker UI will then be able to "view trash", "restore from trash" and "empty trash"

Comment 8

[Chris DeCairos (:cade)]

(In reply to Simon C. Wex from comment #7)
>  - hard delete everything that was deleted 14 days earlier (daily task)
Filed Bug #867982

>  - make sure that you can update a make's deletedAt field to null (this is
> how we do undo delete)
Filed Bug #867986

>  - make sure those with permission (creator of make & admins) can view
> deleted makes
This can be taken care of with this ticket.

>  - figure out how to hard delete through the API
I'll expose this while working on Bug #867982

Comment 9

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/MakeAPI/pull/50

I've modified the search so that it will always apply a filter for the deletedAt field.

I'll build on top of this in the other Delete related bugs.

Comment 10

[Matthew Schranz [:mjschranz]]

Comment on attachment 746942 [details] [review]
https://github.com/mozilla/MakeAPI/pull/50

Code is good.

R+

Comment 12

[[github robot]]

Commit pushed to master at https://github.com/mozilla/MakeAPI

https://github.com/mozilla/MakeAPI/commit/27f0955097d5d141576d831cfa7453368a9fe5dc
Fix Bug 867710 - filter out deleted projects