867741 - Weird text describing when alarms occur (l10n date lib bug)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[James Lal [:lightsofapollo]]

Attachment: Shows multiple units

Really should show less units or some spacing between the "before"'s really the grammar is just quite bad.

Comment 1

[James Lal [:lightsofapollo]]

Showed this to Kevin.. He thinks its related to some l10n refactoring and is going to take a stab at fixing this.

Comment 2

[Kevin Grandon :kgrandon]

Interestingly enough, we could now tweak this output to solve bug 857241. For now I'll check in a fix to limit the display to a single time unit though.

Comment 3

[James Lal [:lightsofapollo]]

To clarify this is any type of event (in this case its just a single instance) with that is broken out into multiple units of time (week, days, etc...)... In my example I set it to fire 9 days prior to the event.

Comment 4

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

This is a super-quick 1-liner fix for the issue we were seeing.

Comment 5

[Kevin Grandon :kgrandon]

This should probably be uplifted.

Comment 6

[James Lal [:lightsofapollo]]

Please see my github comment?

Comment 7

[Kevin Grandon :kgrandon]

Commented. This brings us back to where we should be today. I think we should simply revert and wait to get UX approval for whatever we implement for bug 857241. There would likely be some string changes, so I'd want to get UX on board first.

Comment 8

[Alex Keybl [:akeybl]]

We'd likely take a low risk fix for approval, but this isn't a blocker as described.

Comment 9

[James Lal [:lightsofapollo]]

in master https://github.com/mozilla-b2g/gaia/commit/c5556bf267b32e001198144e37a5fe3cac6387e9

Comment 10

[Jason Smith [:jsmith]]

I think you meant to put qawanted on the other bug, not this one (the one about the syncing failure). If I'm wrong, feel free to explain why.

Comment 11

[Delphine Lebédel [:delphine - OOO]]

Verified fixed on Leo v1.1, Moz Ril
Gaia   fa3d64fad6f3b69be17ebbfdf4b406108afc99f4
BuildID 20130627070213
Version 18.0