867873 - Incorrect radio tech value passed to RIL_REQUEST_SETUP_DATA_CALL request

Status: RESOLVED DUPLICATE of bug 901232

(Core :: DOM: Device Interfaces, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

cf. The comment in ril.h.

https://github.com/mozilla-b2g/android-hardware-ril/blob/master/include/telephony/ril.h#L1516

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Proposed fix

As far as I confirm with a MVNO of NTT docomo, I could not establish data connection without this patch.

Please confirm that other SIMs can be connected with the patch.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Hi, Hiroyuki-san 
I'll try to check this and try to reply to you before weekend.

Thanks

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 744438 [details] [diff] [review]
Proposed fix

Review of attachment 744438 [details] [diff] [review]:
-----------------------------------------------------------------

Hi, Hiroyuki-san

From the ril.h, RIL_REQUEST_SETUP_DATA_CALL still can accept RADIO_TECH_CDMA(0), and RADIO_TECH_GSM(1).
To make the implementation is consistenet with ril.h,
I think the +2 should be done by the caller, setupDataCall in RadioInterfaceLayer.js, 
with adding comments for the reason why doing "+2" on the radioTech.

Also can you help to update the comments for the radioTech in setupDataCall in the ril_worker?

Thanks