Closed Bug 867999 Opened 12 years ago Closed 8 years ago

Leaf address show up twice when using Breakpad unwinder

Categories

(Core :: Gecko Profiler, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: BenWa, Unassigned)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #744627 - Flags: review?(jseward)
Does this prevent recording the leaf address if no unwinder is available? But, if we're going to remove that line, I think we can remove the whole block, unless there are plans to make the 'L' record not a no-op for JSON output.
Also, isn't doSampleStackTrace called only if mUseStackWalk is false (or nonexistent)?
Attachment #744627 - Flags: review?(jseward)
We're not using the breakpad unwinder any more, and I think LUL doesn't have the double leaf function problem.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: