868101 - [traceback] Internal Server Error: /mozpay/pin/create

Status: VERIFIED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P1)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Start the purchase for a paid app
2. Sign in as a new user
3. Create PIN and click continue
4. Click Cancel on the Confirm PIN screen
5. Repeat step #3

Traceback details:
Stacktrace (most recent call last):

  File "webpay/auth/decorators.py", line 43, in wrapper
    return get_standard_step(request, step) or func(request, *args, **kw)
  File "webpay/pin/views.py", line 29, in create
    res = client.change_pin(form.buyer, form.cleaned_data['pin'])

sentry: http://sentry.dmz.phx1.mozilla.com/addons/marketplace-dev-webpay/group/13770/

Comment 1

[Wraithan (Chris McDonald) [:wraithan]]

Ok, so I've gone through the code and the tests. This is all working locally. Mind testing again to see if this was a temporary problem in dev?

Comment 2

[krupa raj[:krupa]]

I just reproduced it again. You should try a few times and eventually you'll hit the error.

Comment 3

[krupa raj[:krupa]]

http request [
POST /mozpay/pin/create HTTP/1.1
Host: marketplace-dev.allizom.org
User-Agent: Mozilla/5.0 (Mobile; rv:18.0) Gecko/18.0 Firefox/18.0
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language: en-US,en;q=0.5
Accept-Encoding: gzip, deflate
Referer: https://marketplace-dev.allizom.org/mozpay/pin/create
Cookie: webpay_anoncsrf=0PZxDtqUsIkCKRh5XESIUaXxVM1VNAqt; webpay_sessionid=556d548319963fb1ddccc8e893ef2fe5
Connection: keep-alive
]
I/PRLog   (  108): 2013-05-13 20:34:18.630762 UTC - 7557072[40404470]: nsHttpTransaction::HandleContentStart [this=4b898680]
Duration:        0.554 4b898680       (marketplace-dev.allizom.org -> POST /mozpay/pin/create)
http response [
HTTP/1.1 500 INTERNAL SERVER ERROR
Server: gunicorn/0.14.6
Vary: Cookie, Accept-Language, Accept-Encoding
Content-Type: text/html; charset=utf-8
Content-Encoding: gzip
Date: Mon, 13 May 2013 20:34:19 GMT
Via: Moz-pp-zlb09
Connection: close
Set-Cookie: webpay_anoncsrf=0PZxDtqUsIkCKRh5XESIUaXxVM1VNAqt; expires=Mon, 13-May-2013 22:34:19 GMT; httponly; Max-Age=7200; Path=/; secure
x-frame-options: DENY
]

Comment 4

[Kumar McMillan [:kumar]]

Is this still happening? I think bug 865291 fixes it

Comment 5

[Wraithan (Chris McDonald) [:wraithan]]

https://github.com/mozilla/webpay/commit/777a2e612e5dc1def856bd187be71850b9722e94

Was passing the wrong thing to `change_pin`.

Comment 6

[krupa raj[:krupa]]

verified fixed