868123 - [MMS] handle messages with bad SMIL/content-id

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Corey Frang [:gnarf]]

Some MMS apps (Handcent on Android) are sending video with incorrect content-id headers, and this causes completely empty parsing.  I feel like if the SMIL content tries to reference an attachment that isn't found we should be rendering the MMS as if there hadn't been any SMIL (just string the attachments together in order)

Comment 1

[Corey Frang [:gnarf]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/9516

Comment 2

[Alex Keybl [:akeybl]]

(In reply to Corey Frang [:gnarf] from comment #0)
> Some MMS apps (Handcent on Android) are sending video with incorrect
> content-id headers, and this causes completely empty parsing.  I feel like
> if the SMIL content tries to reference an attachment that isn't found we
> should be rendering the MMS as if there hadn't been any SMIL (just string
> the attachments together in order)

Is supporting malformed MMS cases a rabbit hole? If so, we may take an approval here but not commit to blocking on incorrect behavior.

Also, how prevalent is this malformed MMS?

Comment 3

[Corey Frang [:gnarf]]

I doubt we will see many of these, but adding a little protective logic to take something where there would be a completely empty message bubble and instead it displays whatever it can.

Comment 4

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

This is easy enough to handle this in a protective way so let's do it. Leo+, or approval, I don't mind. I agree this is less important than the other mms stuff though.

Comment 5

[Rick Waldron [:rwaldron]]

r=me

Comment 6

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

reviewed on the PR. A small change + a question to be answered.

Comment 7

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

Comment on attachment 744772 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/9516

r=me

thanks

Comment 8

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

master: 114bf216de0a19f7a6e2f63234b4a7a37fff9408

Comment 9

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

Comment on attachment 744772 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/9516

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: some badly produced MMS won't show correctly
Testing completed: yes
Risk to taking this patch (and alternatives if risky): low, this code unit is unit tested
String or UUID changes made by this patch: none

This is likely not a blocker but a low-risk nice to have.

Comment 10

[Dylan Oliver [:doliver]]

Triage: tracking+, will leave it to Vivien for approval.

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 114bf216de0a19f7a6e2f63234b4a7a37fff9408 to:
v1-train: b855df38369ad82eae5053796a6a7910d5beb959