868135 - Remove the History sidebar control as a toolbar customization item

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

With Australis, we will now have quite a few history-related items in our customization palette. Bug 855803 implemented the new history widget, and thus we shouldn't have multiple history widgets within our customization palette. Having multiple will just lead to user confusion and make guiding users through our support harder.

The History item that will be removed is the one that toggles the visibility of the History sidebar. We will keep the History item that allows the user to view their bookmarks in a panel/popup as well as convenient access to bookmarking the current page.

This bug is not concerned with removing the history sidebar.

Comment 1

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

I think this is not good for toolbar customization. Of course multiple history widgets in customization palette are not elegant. However, I doubt that we need to unify it to 1 widget.

If user selects the history toolbar widget from palette, he wouldn't use the other one. So there is no multiple history widgets on his toolbar. I feel it's no problem for user, and we would not pay the many cost for its maintenance.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

The other approach we can take here is to rename the History sidebar widget to "History Sidebar" or "History Sidebar Toggle". Having two widgets with the name of "History" will be confusing, but we could also just change the names of them to disambiguate.

Comment 3

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

(In reply to Jared Wein [:jaws] from comment #2)
> The other approach we can take here is to rename the History sidebar widget
> to "History Sidebar" or "History Sidebar Toggle". Having two widgets with
> the name of "History" will be confusing, but we could also just change the
> names of them to disambiguate.

Changing the label sounds good. I think it's easy & effective idea.

Comment 4

[u428464]

(In reply to Jared Wein [:jaws] from comment #2)
> The other approach we can take here is to rename the History sidebar widget
> to "History Sidebar" or "History Sidebar Toggle". Having two widgets with
> the name of "History" will be confusing, but we could also just change the
> names of them to disambiguate.

Having a widget just to toggle a sidebar seems a bit superfluous, but "History sidebar toggle" could become a History subview entry.

Comment 5

[Marco Bonardo [:mak]]

as a note apart, we originally added a toggle to the bookmarks button to show/hide the sidebar, UX asked to remove it, since it's a not so common operations, and sidebars are likely going to disappear in future browsers.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 755594 [details] [diff] [review]
Patch v1

This seems to do the job. Am I missing anything?

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 755594 [details] [diff] [review]
Patch v1

Thanks Jared!

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Landed on UX as https://hg.mozilla.org/projects/ux/rev/24e7badfde21

Comment 10

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/24e7badfde21