868217 - Change - Adjust Sync UI for better information mapping

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Flyouts, defect, P2)

Description

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

Attachment: In comparison- Sync flyout UI

In Bug868099, we decided to replace "Disconnect" label with "Remove this device", to be more accurate. 

And based on our current layout, the "Remove this device" button will be placed besides account details. This is confusing. We need to make adjustments to the current Sync layout. Otherwise changing the label will not make sense.

This is a change that I believe should be done for V1. For V2, please see bug845468 for details.

It's basically just moving around buttons and labels.
1. Move Account details to the top
2. Attach "Remove this device" label button to the device name 
3. Move "Pair a device" to the bottom

Comment 1

[Allison Naaktgeboren :ally]

I would propose making the sync now button accessible via a pref or some other debug means. I know qa, developers, etc rely on it for testing. Rnewman would certainly know more.

Comment 2

[Marco Mucci [:MarcoM]]

Hi Yuan, do you know which story this change is related to?

Comment 3

[Jim Mathies [:jimm]]

(In reply to :Ally Naaktgeboren from comment #1)
> I would propose making the sync now button accessible via a pref or some
> other debug means. I know qa, developers, etc rely on it for testing.
> Rnewman would certainly know more.

It was removed completely in bug 867200 because scheduling a sync doesn't necessarily trigger a sync. We don't want unreliable controls in front of users.

Comment 4

[Richard Newman [:rnewman]]

(In reply to Jim Mathies [:jimm] from comment #3)

> It was removed completely in bug 867200 because scheduling a sync doesn't
> necessarily trigger a sync. We don't want unreliable controls in front of
> users.

There are alternative calls you can use to eliminate the event loop issues you were experiencing. For example, desktop's "Sync Now" menu item does this:

    setTimeout(function() Weave.Service.errorHandler.syncAndReportErrors(), 0);

-- the key part is "do this very soon".

Comment 5

[Jim Mathies [:jimm]]

(In reply to Richard Newman [:rnewman] from comment #4)
> (In reply to Jim Mathies [:jimm] from comment #3)
> 
> > It was removed completely in bug 867200 because scheduling a sync doesn't
> > necessarily trigger a sync. We don't want unreliable controls in front of
> > users.
> 
> There are alternative calls you can use to eliminate the event loop issues
> you were experiencing. For example, desktop's "Sync Now" menu item does this:
> 
>     setTimeout(function() Weave.Service.errorHandler.syncAndReportErrors(),
> 0);
> 
> -- the key part is "do this very soon".

If there's a need for something like this it can be added to a future rev. We're trying to limit functionality rather than add it at this point.

Comment 6

[Jim Mathies [:jimm]]

Discussing at workweek - only thing left to do is remove the descriptive test when sync is connected.

Comment 7

[Jim Mathies [:jimm]]

Attachment: fix

Comment 8

[Allison Naaktgeboren :ally]

Comment on attachment 750086 [details] [diff] [review]
fix

Review of attachment 750086 [details] [diff] [review]:
-----------------------------------------------------------------

1 nit: please remove that icky trailing space in the xul. I know you didn't put it there, but please remove it. :)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2a64d6c74fc2

Comment 10

[Marco Mucci [:MarcoM]]

For testing and verification.

Comment 11

[raymond [:retornam] (inactive)]

verified fixed  FIrefox 24.0a1 (2013-05-28)
built from http://hg.mozilla.org/mozilla-central/rev/c190422547ed

Comment 12

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Change" for iteration #9 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-07-06-03-12-13-mozilla-central/

- Went through the original comment 0 and ensured the "Sync" flyout matched the V1 example that has been attached
- "Sync Now" button has been removed as per discussions in Bug 867200

Comment 13

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130826074752
Built from http://hg.mozilla.org/mozilla-central/rev/14b1e8c2957e

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment0 and ensured the "Sync" flyout matched the V2 example that has been attached. I saw Disconnect instead of Remove from this device.