Closed Bug 868217 Opened 9 years ago Closed 9 years ago

Change - Adjust Sync UI for better information mapping

Categories

(Firefox for Metro Graveyard :: Flyouts, defect, P2)

x86
Windows 8.1
defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 24

People

(Reporter: ywang, Assigned: jimm)

References

Details

(Whiteboard: feature=change c=Install_and_setup u=metro_firefox_user p=1)

Attachments

(2 files)

In Bug868099, we decided to replace "Disconnect" label with "Remove this device", to be more accurate. 

And based on our current layout, the "Remove this device" button will be placed besides account details. This is confusing. We need to make adjustments to the current Sync layout. Otherwise changing the label will not make sense.

This is a change that I believe should be done for V1. For V2, please see bug845468 for details.

It's basically just moving around buttons and labels.
1. Move Account details to the top
2. Attach "Remove this device" label button to the device name 
3. Move "Pair a device" to the bottom
I would propose making the sync now button accessible via a pref or some other debug means. I know qa, developers, etc rely on it for testing. Rnewman would certainly know more.
Hi Yuan, do you know which story this change is related to?
Flags: needinfo?(ywang)
Blocks: metrov1defect&change, 831615
No longer blocks: metrov1triage
Flags: needinfo?(ywang)
Summary: Change - Adjust Sync UI for better information mapping [V1 scope] → Change - Adjust Sync UI for better information mapping
Whiteboard: feature=change c=Install_and_setup u=metro_firefox_user p=0
(In reply to :Ally Naaktgeboren from comment #1)
> I would propose making the sync now button accessible via a pref or some
> other debug means. I know qa, developers, etc rely on it for testing.
> Rnewman would certainly know more.

It was removed completely in bug 867200 because scheduling a sync doesn't necessarily trigger a sync. We don't want unreliable controls in front of users.
Depends on: 849312
(In reply to Jim Mathies [:jimm] from comment #3)

> It was removed completely in bug 867200 because scheduling a sync doesn't
> necessarily trigger a sync. We don't want unreliable controls in front of
> users.

There are alternative calls you can use to eliminate the event loop issues you were experiencing. For example, desktop's "Sync Now" menu item does this:

    setTimeout(function() Weave.Service.errorHandler.syncAndReportErrors(), 0);

-- the key part is "do this very soon".
(In reply to Richard Newman [:rnewman] from comment #4)
> (In reply to Jim Mathies [:jimm] from comment #3)
> 
> > It was removed completely in bug 867200 because scheduling a sync doesn't
> > necessarily trigger a sync. We don't want unreliable controls in front of
> > users.
> 
> There are alternative calls you can use to eliminate the event loop issues
> you were experiencing. For example, desktop's "Sync Now" menu item does this:
> 
>     setTimeout(function() Weave.Service.errorHandler.syncAndReportErrors(),
> 0);
> 
> -- the key part is "do this very soon".

If there's a need for something like this it can be added to a future rev. We're trying to limit functionality rather than add it at this point.
Discussing at workweek - only thing left to do is remove the descriptive test when sync is connected.
Priority: -- → P2
Attached patch fixSplinter Review
Assignee: nobody → jmathies
Attachment #750086 - Flags: review?(ally)
Blocks: metrov1it7
No longer blocks: metrov1defect&change
QA Contact: jbecerra
Whiteboard: feature=change c=Install_and_setup u=metro_firefox_user p=0 → feature=change c=Install_and_setup u=metro_firefox_user p=1
Status: NEW → ASSIGNED
Comment on attachment 750086 [details] [diff] [review]
fix

Review of attachment 750086 [details] [diff] [review]:
-----------------------------------------------------------------

1 nit: please remove that icky trailing space in the xul. I know you didn't put it there, but please remove it. :)
Attachment #750086 - Flags: review?(ally) → review+
https://hg.mozilla.org/mozilla-central/rev/2a64d6c74fc2
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
For testing and verification.
Flags: needinfo?(mozbugs.retornam)
verified fixed  FIrefox 24.0a1 (2013-05-28)
built from http://hg.mozilla.org/mozilla-central/rev/c190422547ed
Status: RESOLVED → VERIFIED
Flags: needinfo?(mozbugs.retornam)
Went through the following "Change" for iteration #9 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-07-06-03-12-13-mozilla-central/

- Went through the original comment 0 and ensured the "Sync" flyout matched the V1 example that has been attached
- "Sync Now" button has been removed as per discussions in Bug 867200
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130826074752
Built from http://hg.mozilla.org/mozilla-central/rev/14b1e8c2957e

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment0 and ensured the "Sync" flyout matched the V2 example that has been attached. I saw Disconnect instead of Remove from this device.
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.