Closed Bug 868232 Opened 7 years ago Closed 7 years ago

Paris binding for MozStkCommandEvent

Categories

(Core :: DOM: Events, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(2 files)

I haven't figured out how to compile icc stuff on desktop so it is not clear to
me whether this works. Well, I know Bindings.conf stuff are missing.
ah, maybe I figured out how to compile icc.
Attached patch patchSplinter Review
https://tbpl.mozilla.org/?tree=Try&rev=50e5c1f84512

This could use some manual testing.
Assignee: nobody → bugs
Attachment #744917 - Flags: review?(peterv)
Attachment #744917 - Flags: feedback?(allstars.chh)
Blocks: 776864
Comment on attachment 744917 [details] [diff] [review]
patch

Review of attachment 744917 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/icc/src/StkCommandEvent.h
@@ +58,5 @@
> +    JS::Rooted<JS::Value> retVal(aCx);
> +    aRv = GetCommand(aCx, retVal.address());
> +    return retVal;
> +  }
> +  

nit, trailing space.
Attachment #744917 - Flags: feedback?(allstars.chh) → feedback+
Attachment #744917 - Flags: review?(peterv) → review+
https://hg.mozilla.org/mozilla-central/rev/f8e522d6991f
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.