868278 - ProtocolCompatibility should only use promise rejections to indicate exceptions, not false results

Status: RESOLVED INVALID

(DevTools :: Debugger, defect, P2)

Description

[Jim Blandy :jimb]

Attachment: In the debugger client's ProtocolCompatibility, save promise rejection for exceptions, not false results.

If we're going to log unhandled promise rejections, and treat them as test failures, then the debugger client's ProtocolCompatibility should not use rejection to announce that a feature isn't present. Instead, it should pass 'true' or 'false' to its resolution handler.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 744962 [details] [diff] [review]
In the debugger client's ProtocolCompatibility, save promise rejection for exceptions, not false results.

Review of attachment 744962 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great!

Would like to see a green try push just as a formality.

The previous behavior wasn't causing problems was it? If so, sorry!

Final note, I'm not a module peer so you need to get one more person to sign off on this before it can land ;)

::: toolkit/devtools/debugger/dbg-client.jsm
@@ +1182,5 @@
> +              return {
> +                sources: [
> +                  { url: url, actor: sourceActorsByURL[url] }
> +                  for (url of Object.keys(sourceActorsByURL))
> +                    ]

Nit: indentation looks a little off here with the closing square bracket.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Are we still doing this?

Comment 3

[Eddy Bruel [:ejpbruel]]

Nick, didn't you get rid of this code completely?

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Yup, gone in bug 1090594.