Closed Bug 868286 Opened 11 years ago Closed 11 years ago

When Home key is pressed 2times quickly, the footer of the wrapper is not disappear in Homescreen

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
critical

Tracking

(blocking-b2g:leo+, b2g18 fixed)

RESOLVED FIXED
blocking-b2g leo+
Tracking Status
b2g18 --- fixed

People

(Reporter: leo.bugzilla.gaia, Assigned: crdlc)

References

Details

Attachments

(2 files)

Step : Go to evme and click any cetegory. Launch any app and click the home key 2 times quickly. Then footer is not disappear when go to homescreen. 
It is reprocuded in the master git & v1-train. It is ver similar with 823889.
Attached image Attach the screenshot
blocking-b2g: --- → leo?
Taking a look
Component: Gaia::Everything.me → Gaia::System
Summary: [Homescreen:Everythine.me] When Home key is pressed 2times quickly, the footer of the wrapper is not disappear in Homescreen → When Home key is pressed 2times quickly, the footer of the wrapper is not disappear in Homescreen
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
I can reproduce the bug perfectly with the STR provided, thanks a lot. Taking a look, the patch is very easy, no risk
Whiteboard: DUPEME
dupe of 856492 I believe.
Attached file Patch v1
Attachment #745040 - Flags: review?
Attachment #745040 - Flags: review? → review?(21)
Or Alive, if you want to review this, feel free my friend
Comment on attachment 745040 [details]
Patch v1

r=me for leo+ time frame solution.
Attachment #745040 - Flags: review?(21) → review+
Yes I know, the goal is your patch, but til that moment, it fixes the problem. The cause was what when an user tries to click twice or more very fast, when the flow enter in the callback the closeFrame is null so the code where the footer is hidden is not reached. It only moves these code at the beginning of the function in order to check if the classList contains the class calles 'visible'
https://github.com/mozilla-b2g/gaia/commit/5961808d2f9444771147bc593df4f063ecb8cbfe

Thanks Alive and great work you are doing decoupling all the code, thanks
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Fine, now I don't have any timeframe pressure to do it ;)
blocking-b2g: leo? → leo+
Uplifted 5961808d2f9444771147bc593df4f063ecb8cbfe to:
v1-train: 19a3015a88dcf20cda5ec5e924bc1082ab7c714f
Whiteboard: DUPEME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: