Convert assertions.js and stack.js to an old style module to be loadable by controller.js

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: daniela.p98911, Assigned: whimboo)

Tracking

Details

(Whiteboard: [mozmill-2.0+][ateamtrack: p=mozmill q=2013q2 m=2])

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
This bug was discovered while trying to use assert.waitFor inside the controller.js (bug 791634). We need to change assertions.js so that assert and expect can be used outside the module loader. Controller.js is not loaded through the module loader so assert and expect are undefined if used inside it.
(Reporter)

Updated

5 years ago
Blocks: 791634
Whiteboard: [mozmill-2.0?]
(Assignee)

Updated

5 years ago
Summary: Change assertions.js to be used outside module loader → Convert assertions.js to an old style module to be loadable by controller.js
(Assignee)

Updated

5 years ago
Assignee: nobody → hskupin
Summary: Convert assertions.js to an old style module to be loadable by controller.js → Convert assertions.js and stack.js to an old style module to be loadable by controller.js
(Assignee)

Comment 1

5 years ago
Created attachment 745899 [details] [diff] [review]
Patch v1

With this change we will be able to make use of the assertions module in the controller.js and utils.js module. It's needed to get various soft waitfor's implemented.
Attachment #745899 - Flags: review?(ctalbert)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED

Comment 2

5 years ago
Comment on attachment 745899 [details] [diff] [review]
Patch v1

Review of attachment 745899 [details] [diff] [review]:
-----------------------------------------------------------------

r+
Attachment #745899 - Flags: review?(ctalbert) → review+
(Assignee)

Comment 3

5 years ago
Landed on master:
https://github.com/mozilla/mozmill/commit/296efdb27b1d6bc32c70d211869d311265f46dd4
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [mozmill-2.0?] → [mozmill-2.0?][ateamtrack: p=mozmill q=2013q2 m=2]
(Assignee)

Comment 4

5 years ago
Sorry, but I missed to update the appropriate test for assertions. Follow-up patch is coming.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 5

5 years ago
Created attachment 746872 [details] [diff] [review]
Fix for expect_assert.js
Attachment #746872 - Flags: review?(andreea.matei)
Comment on attachment 746872 [details] [diff] [review]
Fix for expect_assert.js

Review of attachment 746872 [details] [diff] [review]:
-----------------------------------------------------------------

Looks and works fine.
Attachment #746872 - Flags: review?(andreea.matei) → review+
(Assignee)

Comment 7

5 years ago
Landed fix for the assertions test:
https://github.com/mozilla/mozmill/commit/2754ac996986f3926dfa9777e1341f2259f7890f
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Whiteboard: [mozmill-2.0?][ateamtrack: p=mozmill q=2013q2 m=2] → [mozmill-2.0+][ateamtrack: p=mozmill q=2013q2 m=2]
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.