868388 - [Building Blocks] Filters should be updated to the latest version

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Sergi]

Attachment: New Filters

Comment 1

[Sergi]

Filters have been updated in the Common Controls file: https://www.dropbox.com/s/xaohxz39nh9ft7u/CommonControls_20130305.jpg 

we should update the building block to match this update.

Comment 2

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: Patch

Comment 3

[Ismael Gonzalez [:basiclines]]

Comment on attachment 746373 [details]
Patch

This changes look good to me as we ensure we do not break anything.
If we break something we should take care on creating new bugs and fixing them.
Thx!

Comment 4

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 746373 [details]
Patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: yes
Risk to taking this patch (and alternatives if risky): this patch is affecting cost control app, and call log where visual styles are not applied correctly. We are trying to fix it ASAP.
String or UUID changes made by this patch:

Comment 5

[Alex Keybl [:akeybl]]

(In reply to arnau from comment #4)
> Risk to taking this patch (and alternatives if risky): this patch is
> affecting cost control app, and call log where visual styles are not applied
> correctly. We are trying to fix it ASAP.

Before uplifting, please list all apps that need to be QA verified on master/m-c.

Comment 6

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Alex,
we have reviewed email (which was fixed in this patch), call log (https://bugzilla.mozilla.org/show_bug.cgi?id=869446) and cost control (https://bugzilla.mozilla.org/show_bug.cgi?id=869485).
They are all ok for our side, please make sure those 2 bugs are uplifted together.

AFAIK Email, Call log (Comms) and Cost control are the only apps using filters Building Block.
Thanks!

Comment 7

[Alex Keybl [:akeybl]]

(In reply to arnau from comment #6)
> AFAIK Email, Call log (Comms) and Cost control are the only apps using
> filters Building Block.
> Thanks!

Who's in position to say this with confidence?

Comment 8

[Ismael Gonzalez [:basiclines]]

grep -r "style_unstable/tabs.css" apps
apps/communications/dialer/index.html:    <link rel="stylesheet" type="text/css" href="/shared/style_unstable/tabs.css">
apps/costcontrol/index.html:    <link rel="stylesheet" type="text/css" href="shared/style_unstable/tabs.css">
apps/email/index.html:  <link rel="stylesheet" type="text/css" href="shared/style_unstable/tabs.css"/>

:D

Comment 9

[Maria Angeles Oteo (:oteo)]

(In reply to Alex Keybl [:akeybl] from comment #7)
> (In reply to arnau from comment #6)
> > AFAIK Email, Call log (Comms) and Cost control are the only apps using
> > filters Building Block.
> > Thanks!
> 
> Who's in position to say this with confidence?

Ismael has alraedy confirmed it: Email, Call log (Comms) and Cost control

Comment 10

[Alex Keybl [:akeybl]]

Comment on attachment 746373 [details]
Patch

If/when we find any critical regressions, we'll back this out of v1.1. Approving for now.

Comment 11

[Gareth Aye [:gaye] (back from PTO)]

Arnau,

Please mirror the sha from git into bugzilla so that it's easier to find for uplifting to v1-train in the future :).

Landed on master: 1c1aa726652d3c4b4e803beec11b07de0b6ba5f5

Comment 12

[Gareth Aye [:gaye] (back from PTO)]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 1c1aa726652d3c4b4e803beec11b07de0b6ba5f5
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 13

[Maria Angeles Oteo (:oteo)]

Arnau, can you help with the uplift?

Comment 14

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

v1-train: c8bf41bbf92e7ff5de72de8e9ba19d8762a92a76