868391 - [Building Blocks] Alerts should be updated to the latest version

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Sergi]

Attachment: New Alert

Alerts have been updated in the Common Controls file: https://www.dropbox.com/s/xaohxz39nh9ft7u/CommonControls_20130305.jpg 

we should update the building block to match this update.

Comment 1

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch to github

Comment 2

[Ismael Gonzalez [:basiclines]]

Comment on attachment 745114 [details]
patch to github

Everything looks good

Comment 3

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 745114 [details]
patch to github

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: not matching visual style
Testing completed: yes
Risk to taking this patch (and alternatives if risky): very low, just CSS
String or UUID changes made by this patch:

Comment 4

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 8513e27db3232a71a2e3eec90c8985930cd48540
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 5

[Maria Angeles Oteo (:oteo)]

Arnau or Isma, could you help John with th uplift to v1-train?

Comment 6

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

v1-train: ba61586cdb80791369e07be4e609e6369f04621c

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Thanks for the resolution.  V1-train is currently v1.1.0, and we're using the status-b2g18 flag for that.

fixing flag