Closed Bug 868396 Opened 7 years ago Closed 7 years ago

Don't work the pref "ui.useOverlayScrollbars"

Categories

(Core :: Widget: Cocoa, defect)

x86_64
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: tetsuharu, Assigned: spohl)

References

Details

(Whiteboard: [lion-scrollbars+])

Attachments

(1 file)

[Environment]
http://hg.mozilla.org/mozilla-central/rev/b35170667a2f

Don't work the pref "ui.useOverlayScrollbars" after restart the browser.
It does not switch the look and feel of OS X Lion styled scrollbar.
Attached patch PatchSplinter Review
Calling nsLookAndFeel::UseOverlayScrollbars directly in nsNativeThemeCocoa.mm caused us to skip the call to nsXPLookAndFeel::GetIntImpl at the top of nsLookAndFeel::GetIntImpl, which would have told us if the user manually set "ui.useOverlayScrollbars".
Attachment #745273 - Flags: review?(smichaud)
Comment on attachment 745273 [details] [diff] [review]
Patch

Looks fine to me.
Attachment #745273 - Flags: review?(smichaud) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/79b17d0c3d3a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.