Remove deprecated methods in Tabzilla.js (2013-08-01)

VERIFIED FIXED

Status

P3
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: icaaq, Unassigned)

Tracking

Details

(Reporter)

Description

5 years ago
Tabzilla.js now includes some deprecated methods:

Tabzilla.opened();
Tabzilla.closed();

This bug is just a reminder to removes those methods around TOPIC date.

cc: :sgarrity
(In reply to Isac Lagerblad (:icaaq) from comment #0)
> Tabzilla.js now includes some deprecated methods:
> 
> Tabzilla.opened();
> Tabzilla.closed();
> 
> This bug is just a reminder to removes those methods around TOPIC date.
> 
> cc: :sgarrity

Isac can we keep these so we could use them to toggle the dropdown when testing with selenium?
(Reporter)

Comment 2

5 years ago
(In reply to raymond [:retornam] from comment #1)
> (In reply to Isac Lagerblad (:icaaq) from comment #0)
> > Tabzilla.js now includes some deprecated methods:
> > 
> > Tabzilla.opened();
> > Tabzilla.closed();
> > 
> > This bug is just a reminder to removes those methods around TOPIC date.
> > 
> > cc: :sgarrity
> 
> Isac can we keep these so we could use them to toggle the dropdown when
> testing with selenium?

Could you please change the calls to Tabzilla.open() and Tabzilla.close() instead.

Updated

5 years ago
Assignee: nobody → mozbugs.retornam
Priority: -- → P3
I have updated the tests to use Tabzilla.open and Tabzilla.close and removed the deprecated methods in this pull request https://github.com/mozilla/bedrock/pull/854

Comment 4

5 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/d8f173f08182e606784c95bcca1a24d6d0929c18
Bug 868413 remove deprecated methods from Tabzilla

https://github.com/mozilla/bedrock/commit/ece0e8ad98a0fa901d8284a95509472c1160255a
Merge pull request #854 from retornam/bug-868413-remove-tabzilla-methods

Bug 868413 remove deprecated methods from Tabzilla
Tests were updated, so we're going ahead and removing now.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
fixed on stage
fixed on prod
Status: RESOLVED → VERIFIED
Assignee: mozbugs.retornam → nobody

Updated

5 years ago
Component: Pages & Content → Tabzilla
Product: www.mozilla.org → Websites
Target Milestone: --- → 1.5
Sorry for the bugspam -- the Target Milestore was set unexpectedly.
Target Milestone: 1.5 → ---
You need to log in before you can comment on or make changes to this bug.