Closed Bug 868452 Opened 7 years ago Closed 7 years ago

Fix entity name (&brandShortName;) and string consistency in gclicommands.properties

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 23

People

(Reporter: flod, Assigned: flod)

References

()

Details

Attachments

(1 file)

New strings landed with some issues in bug 855914 (see comment 26 and following)

1) Use of &brandShortName; in a .properties file. To fix this issue strings will need a new entity name.

2) Inconsistent use of "built-in" vs "builtin" (can be fixed without renaming).

3) Check if the different format used in toolsReloaded is really wanted. To fix this, if needed, that label will have to be renamed

toolsBuiltinReloaded=Built-in tools loaded.
toolsReloaded="Tools reloaded."
I think we need to fix this as soon as possible, considering that next Tuesday it will slip to Aurora.
I wanted to have a better understanding of the code behind the plural form, so I tried to prepare a patch.

I've also changed the toolsReloaded string removing quotes (not sure if you want that).

I hope I'm not missing something obvious.
Attachment #746838 - Flags: review?(dcamp)
Comment on attachment 746838 [details] [diff] [review]
Patch fixing brandShortName replacement and string consistency

Review of attachment 746838 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #746838 - Flags: review?(dcamp) → review+
Thanks Dave, is this going to be committed directly or do I need to add a keyword?
Assignee: nobody → francesco.lodolo
(In reply to Francesco Lodolo [:flod] from comment #4)
> Thanks Dave, is this going to be committed directly or do I need to add a
> keyword?

When you want someone to push the change for you, you have to add the keyword "checkin-needed".
I pushed it for you :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/671e9ced84bc
(In reply to Théo Chevalier [:tchevalier] from comment #5)
> (In reply to Francesco Lodolo [:flod] from comment #4)
> When you want someone to push the change for you, you have to add the
> keyword "checkin-needed".
> I pushed it for you :)

Not sure why but I thought (remembered) that devtools work differently.

Thanks Théo ;-)
https://hg.mozilla.org/mozilla-central/rev/671e9ced84bc
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Verified Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:23.0) Gecko/20130510 Firefox/23.0
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.