868550 - [Bluetooth] - replace some css styles with [BB]

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Description

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Replace:
<link rel="stylesheet" type="text/css" href="style/bb/value_selector.css" />
<link rel="stylesheet" type="text/css" href="style/bb/menus-dialogues/core.css" />
<link rel="stylesheet" type="text/css" href="style/bb/menus-dialogues/prompt/style.css" />

with:
[BB][confirm] styles

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia repo

Hey Arnau,
I change some css references can you check them? ... and I found some other bug ... if you try to select pair device from value selector ... nothing happens

Comment 2

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Pavel, the PR for your patch is closed, sorry it took me so long.
Do you still need me to review this?

Comment 3

[Eric Pang [:epang] UX]

(In reply to Arnau March from comment #2)
> Pavel, the PR for your patch is closed, sorry it took me so long.
> Do you still need me to review this?

Hey Pavel, can you look into this for Arnau? Thanks!

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

I totally forgot for this one ... I will create new patch and ping you back Arnau. Thanks Eric :)

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey guys,
because of Bug 863323 we can't load [BB] here ... I think we should wait for next version of [BB]'s. Arnau, what do you think?

Comment 6

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Ok, let's wait for the new BB, as it is a critical issue.

Comment 7

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

I meant as is "not" a critical issue.

Comment 8

[Eric Pang [:epang] UX]

(In reply to Arnau March from comment #7)
> I meant as is "not" a critical issue.

Hey guys, is this something we can work on for 1.3?

Comment 9

[[e-mail], [e-mail]]

Hi Pavel,

The patch is needed to update since the customised value-selector is removed already. We replaced the devices list panel with Settings::Bluetooth style.

Comment 10

[Eric Pang [:epang] UX]

Flagging as 1.3? based on Ian's comment.

Comment 11

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Looks like this patch is already merged

Comment 12

[[e-mail], [e-mail]]

Shall we close the issue for QA verification?

Comment 13

[Eric Pang [:epang] UX]

(In reply to Ian Liu [:ianliu] from comment #12)
> Shall we close the issue for QA verification?

Naoki, can you help us verify this?  Then we can close :). Thanks!

Comment 14

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Looks like this was where the changes got pushed:
https://github.com/mozilla-b2g/gaia/commit/8d5ae6f7d1b874e214ade29f9fd78b7cc49d7e47

Still looking at the code to verify that everything in the patch matches with the changes requested.

Comment 15

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Comparing this checkin to b2g master, I did see some differences:

https://github.com/mozilla-b2g/gaia/blob/master/apps/bluetooth/transfer.html#L53
<button class="full" id="alert-button-ok" data-l10n-id="ok">OK</button>

Shouldn't this be :  <button class="full danger" id="alert-button-ok" data-l10n-id="ok">OK</button> 
?

Also are we skipping the dialog for bluetooth not being paired and setting up the pairing?  (That would make sense to me)

Comment 16

[Eric Pang [:epang] UX]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #15)
> Comparing this checkin to b2g master, I did see some differences:
> 
> https://github.com/mozilla-b2g/gaia/blob/master/apps/bluetooth/transfer.
> html#L53
> <button class="full" id="alert-button-ok" data-l10n-id="ok">OK</button>
> 
> Shouldn't this be :  <button class="full danger" id="alert-button-ok"
> data-l10n-id="ok">OK</button> 
> ?
> 
> Also are we skipping the dialog for bluetooth not being paired and setting
> up the pairing?  (That would make sense to me)

Thanks Naoki!  Pavel, can take a look into Naoki's comments? Thanks!

Comment 17

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 745526 [details]
patch for Gaia repo

This one is obsolate and I thing we nee to close this bug for now ... I open new one by Naoki's comment #931555

Comment 18

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Closing based on the new bug 931555

Comment 19

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Marking as verified.

there seems to be a performance issue.
I didn't find the bluetooth not paired dialog useful, so I'm glad we've skipped it.

Gaia   412fd463bcb81f0e8bebf6d32500d0c02712748d
SourceStamp f0d363d72753
BuildID 20131031040201
Version 28.0a1
buri

Comment 20

[Preeti Raghunath(:Preeti)]

Naoki,

What is the hit to performance here?

Can we please compare with 1.2 to check if QC will be impacted?

Comment 21

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

bug 949669.  Thanks for reminding me to open the bug.

Comment 22

[Jason Smith [:jsmith]]

No patch attached here, so removing blocking flag.