868595 - Search Box in about:home does not work in Private Window

Status: RESOLVED DUPLICATE of bug 866254

(Firefox :: Tabbed Browser, defect)

Description

[Alice0775 White]

uild Identifier:
http://hg.mozilla.org/mozilla-central/rev/b35170667a2f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20130503 Firefox/23.0 ID:20130503030920

This is spun off from Bug 866254, because regression window is different

This is may be 32bit build of Firefox specic bug.
For 64bit build of Firefox, see Bug 866254.


Steps To Reproduce:

Steps to reproduce:
1. make sure default Private Browsing
   Options -> Privacy and select "never remember history"
2. Restart Firefox.
3. Open about:home
3. Type something in the textbox  in about:home and Enter/Click Search Button

Actual results:
 nothing happens.

Expected results:
 a search should be performed.



Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/31268d71c33c
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130202 Firefox/21.0 ID:20130203063220
Bad:
http://hg.mozilla.org/mozilla-central/rev/847e28c7ba67
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130203 Firefox/21.0 ID:20130203123521
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=31268d71c33c&tochange=847e28c7ba67

Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/0a072eb27f1d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130201 Firefox/21.0 ID:20130201100308
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/8728de36d4a8
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130201 Firefox/21.0 ID:20130201104405
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=0a072eb27f1d&tochange=8728de36d4a8

Triggered by :
96302c19380f	Frank Yan — Bug 837061 - Use plain JS property for tab._fullyOpen to decouple from binding destruction upon tab movement. r=dao

Comment 1

[Alice0775 White]

Error in error console:

Error: DEPRECATION WARNING: Search service falling back to deprecated synchronous initializer.
You may find more details about this deprecation at: https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIBrowserSearchService#async_warning
resource://gre/components/nsSearchService.js 3850 epsSyncInit
resource://gre/components/nsSearchService.js 2589 SRCH_SVC__ensureInitialized
resource://gre/components/nsSearchService.js 3557 null
resource://app/modules/AboutHomeUtils.jsm 26 null
chrome://browser/content/browser.js 10456 BrowserOnAboutPageLoad
chrome://browser/content/browser.js 12406 TabsProgressListener.onStateChange
chrome://browser/content/tabbrowser.xml 413 null
chrome://browser/content/tabbrowser.xml 410 _callProgressListeners
chrome://browser/content/tabbrowser.xml 457 ._callProgressListeners
chrome://browser/content/tabbrowser.xml 618 .onStateChange
null 0 null

Source File: resource://gre/modules/Deprecated.jsm
Line: 79


Error: [Exception... "'Error: Internal error: invalid state FINISHED_SUCCESS' when calling method: [nsIBrowserSearchService::defaultEngine]"  nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)"  location: "JS frame :: resource://app/modules/AboutHomeUtils.jsm :: <TOP_LEVEL> :: line 26"  data: no]
Source File: chrome://browser/content/tabbrowser.xml
Line: 417

Comment 2

[bhavana bajaj [:bajaj]]

Passing this onto :fryn as this is a regression from Bug 837061.
fryn, can we perform a backout of Bug 837061(on all branches) to help resolve this ? I do not see anything in the dependency tree on that bug hence backout may be a safer option given we goto build with our final beta on Monday.

Comment 3

[Frank Yan (:fryn)]

(In reply to Alice0775 White from comment #0)

(In reply to bhavana bajaj [:bajaj] from comment #2)
> Passing this onto :fryn as this is a regression from Bug 837061.

Are you sure that that changeset caused the bug? That change doesn't have anything to do with the search engine code.

If it indeed is the problem, I can only think of it being a race condition stemming from lower-level problems.

We can back out that changeset, but I'm not convinced that it's the root of the problem, and backing it out may cause other problems.

Comment 4

[Alice0775 White]

OK,
I backed out patch of Bug 837061 from Nightly 32bit by manually.
The problem seemed to be fixed.

However, I run the browser with the condition that have very high load of HDD.
1. Newly opened private window --- the problem is reproduced
2. Open another "about:home" in new tab --- the problem is not reproduced

So, as :fryn commented，Bug 837061 is not root cause.