868599 - Use the gaia pointer in gecko when creating B2G desktop builds in buildbot

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Jonathan Griffin (:jgriffin)]

After we add a pointer to gaia into m-c, we should begin using that gaia revision to create B2G desktop builds in buildbot.

Comment 1

[Aki Sasaki (not active)]

We're going to also have to split behavior between b2g18* (no gaia.json) and m-c based repos (gaia.json).

Comment 2

[Aki Sasaki (not active)]

Attachment: (custom) [needs testing] use gaia.json

Comment 3

[Aki Sasaki (not active)]

Attachment: (configs) [needs testing] use gaia.json

Comment 4

[Aki Sasaki (not active)]

Hm, I need to redo the configs to allow for gaia.json usage on try.

Two things:

1) Once I do that, try will use gaia.json, even if you're pushing from b2g18*.  So b2g18* b2g desktop builds on try will be bogus without this file.

2) Since the factory is expecting the repo path to be the path portion of the url, not the server, I'm ignoring the repo portion of the file.

I could urlparse it, or we could just specify the repo_path (e.g. integration/gaia-central), or we can make the repo ignorable and point to the appropriate repo_path in buildbot-configs.

Needinfo-ing :jgriffin since I think the above two points are important to note, and correct early if needed.

Comment 5

[Aki Sasaki (not active)]

Attachment: (configs) use gaia.json; enable try gaia.json

Comment 6

[Aki Sasaki (not active)]

Attachment: (custom) [needs testing] use gaia.json, try to use repo

This is mostly ok, but the dang mirrors portion of the makeHgtoolStep() call doesn't seem to play nicely with a partial WithProperties self.gaiaRepo.
http://hg.mozilla.org/build/buildbotcustom/file/cf7133c180d2/process/factory.py#l1189

And if I set self.gaiaRepoUrl to one thing from the gaia.json, and the mirrors are something completely different, I'm probably going to hit issues.  Probably on gaia-try.

Frustrating.

Comment 7

[Jonathan Griffin (:jgriffin)]

(In reply to Aki Sasaki [:aki] from comment #4)
> Hm, I need to redo the configs to allow for gaia.json usage on try.
> 
> Two things:
> 
> 1) Once I do that, try will use gaia.json, even if you're pushing from
> b2g18*.  So b2g18* b2g desktop builds on try will be bogus without this file.

Currently, if someone pushes from b2g18 to try, they would end up using gaia master, right?  That's a bogus config too.  I think the answer is, "we don't support gaia tests on try for mozilla-b2g18".

> 
> 2) Since the factory is expecting the repo path to be the path portion of
> the url, not the server, I'm ignoring the repo portion of the file.
> 
> I could urlparse it, or we could just specify the repo_path (e.g.
> integration/gaia-central), or we can make the repo ignorable and point to
> the appropriate repo_path in buildbot-configs.

I think either of these would be ok.  For clarity, maybe we should specify repo_path (so people who are looking at the file or manually updating it for a try run aren't confused about where it points to).

> 
> Needinfo-ing :jgriffin since I think the above two points are important to
> note, and correct early if needed.

Comment 8

[Aki Sasaki (not active)]

Ok.  And true, re: b2g18 try.

Comment 9

[Aki Sasaki (not active)]

Attachment: (custom) [needs testing] use gaia.json, fix mirrors?, use re.search =\

I may have fixed the mirrors issue I was whining about earlier.

Fun part about this patch? The json.loads() was barfing, so I'm using re.search() to parse the json to try to figure out the repo/revision. Fun fun fun.

I'm using urlparse to get the repo path until we actually change the gaia.json contents, so I don't have to fork m-c to test.

Comment 10

[Aki Sasaki (not active)]

Attachment: (custom) [needs testing] as above, but passes checkconfig

Comment 11

[Aki Sasaki (not active)]

The re.search is stackdumping as well. Trying to figure out what is wrong.

Comment 12

[Aki Sasaki (not active)]

Attachment: (custom) working, uses urlparse.urlparse to build gaia repo path

Comment 13

[Aki Sasaki (not active)]

Attachment: update gaia.json with repo_path

Updating the revision while I'm here, but the important part is getting the repo_path in instead of the repo url.

Comment 14

[Aki Sasaki (not active)]

Comment on attachment 759000 [details] [diff] [review]
(configs) use gaia.json; enable try gaia.json

This worked in staging, with the m-c linux32_gecko_localizer nightly.
I'm not sure if I prefer clumping the b2g18* platforms together, or if I should clump all the gaia_revision_file bits together with a comment at the top.

Comment 15

[Aki Sasaki (not active)]

Attachment: (custom) use repo_path instead of urlparse

Comment 16

[[e-mail] (:bhearsum)]

Comment on attachment 759000 [details] [diff] [review]
(configs) use gaia.json; enable try gaia.json

Review of attachment 759000 [details] [diff] [review]:
-----------------------------------------------------------------

I like this bug, it seems like a win.

Comment 17

[Jonathan Griffin (:jgriffin)]

Comment on attachment 759554 [details] [diff] [review]
update gaia.json with repo_path

Review of attachment 759554 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 18

[Aki Sasaki (not active)]

Comment on attachment 759554 [details] [diff] [review]
update gaia.json with repo_path

https://hg.mozilla.org/integration/mozilla-inbound/rev/195a1146daa0

Comment 19

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/195a1146daa0

Comment 20

[Aki Sasaki (not active)]

Comment on attachment 759000 [details] [diff] [review]
(configs) use gaia.json; enable try gaia.json

http://hg.mozilla.org/build/buildbot-configs/rev/4915cd411d3b

Comment 21

[Aki Sasaki (not active)]

Comment on attachment 759557 [details] [diff] [review]
(custom) use repo_path instead of urlparse

http://hg.mozilla.org/build/buildbotcustom/rev/f1608e939e30

Comment 22

[Aki Sasaki (not active)]

This is in production.

Comment 23

[Jonathan Griffin (:jgriffin)]

Nice!

Comment 24

[Aki Sasaki (not active)]

And I see it working.