Closed Bug 868635 Opened 7 years ago Closed 7 years ago

Stop relying on the default global in CC heuristics

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attachment #745411 - Flags: review?(continuation)
Fixed up some orange.
Attachment #745411 - Attachment is obsolete: true
Attachment #745411 - Flags: review?(continuation)
Attachment #745456 - Flags: review?(continuation)
Comment on attachment 745456 [details] [diff] [review]
Make merging CC heuristics go through scx. v2

Review of attachment 745456 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know the functions you are calling here very well, but it looks reasonable to me.

::: dom/base/nsJSEnvironment.cpp
@@ +2538,5 @@
>  
>    JS::ShrinkGCBuffers(nsJSRuntime::sRuntime);
>  }
>  
> +// Return true if any JSContext default global whose current inner is gray.

"Return true if there is any" maybe?
Attachment #745456 - Flags: review?(continuation) → review+
https://hg.mozilla.org/mozilla-central/rev/0550d3d146cf
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.