868658 - OdinMonkey: also require explicit coercion of function-pointer calls

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

This is a followup to bug 864600 to also require explicit coercion of function-pointer calls for the same reason as before.

Comment 1

[Luke Wagner [:luke]]

Attachment: patch

Simple fix and, thankfully, Epic Citadel and all the other Emscripten demos I tried still validate.

Comment 2

[Sean Stangl [:sstangl]]

Comment on attachment 745432 [details] [diff] [review]
patch

Review of attachment 745432 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/AsmJS.cpp
@@ +3357,5 @@
>      if (!f.funcPtrCall(*table, indexDef, args, def))
>          return false;
>  
> +    if (!(table->sig().returnType() <= use))
> +        return f.fail("return type of callee not compatible with use", callNode);

"incompatible"?

Comment 3

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ffa5c9610cba

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ffa5c9610cba