Closed
Bug 868658
Opened 9 years ago
Closed 9 years ago
OdinMonkey: also require explicit coercion of function-pointer calls
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: luke, Assigned: luke)
Details
Attachments
(1 file)
6.18 KB,
patch
|
sstangl
:
review+
|
Details | Diff | Splinter Review |
This is a followup to bug 864600 to also require explicit coercion of function-pointer calls for the same reason as before.
![]() |
Assignee | |
Comment 1•9 years ago
|
||
Simple fix and, thankfully, Epic Citadel and all the other Emscripten demos I tried still validate.
Attachment #745432 -
Flags: review?(sstangl)
Comment 2•9 years ago
|
||
Comment on attachment 745432 [details] [diff] [review] patch Review of attachment 745432 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/ion/AsmJS.cpp @@ +3357,5 @@ > if (!f.funcPtrCall(*table, indexDef, args, def)) > return false; > > + if (!(table->sig().returnType() <= use)) > + return f.fail("return type of callee not compatible with use", callNode); "incompatible"?
Attachment #745432 -
Flags: review?(sstangl) → review+
![]() |
Assignee | |
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ffa5c9610cba
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ffa5c9610cba
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•