Closed
Bug 868674
Opened 12 years ago
Closed 12 years ago
IonMonkey: Make supportsFloatingPoint() and friends static methods
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: sstangl, Assigned: sstangl)
Details
Attachments
(1 file, 1 obsolete file)
|
7.70 KB,
patch
|
sstangl
:
review+
|
Details | Diff | Splinter Review |
Asking for supportsFloatingPoint() in JitSupportsFloatingPoint() requires construction of an immediately-discarded MacroAssembler. Instead, the method should be static.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #776036 -
Flags: review?(hv1989)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 776036 [details] [diff] [review]
Make supportsFloatingPoint a static function.
Review of attachment 776036 [details] [diff] [review]:
-----------------------------------------------------------------
I see no downside to this.
Attachment #776036 -
Flags: review?(hv1989) → review+
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 3•12 years ago
|
||
I've been trying to land this patch for something like three days, but the tree is perpetually closed. Trying with checkin-needed instead.
Attachment #776036 -
Attachment is obsolete: true
Attachment #778076 -
Flags: review+
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f74c23e8686
and no: even in Europe it's not easy to land things, nowadays ...
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•