Closed Bug 868674 Opened 7 years ago Closed 6 years ago

IonMonkey: Make supportsFloatingPoint() and friends static methods

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: sstangl, Assigned: sstangl)

Details

Attachments

(1 file, 1 obsolete file)

Asking for supportsFloatingPoint() in JitSupportsFloatingPoint() requires construction of an immediately-discarded MacroAssembler. Instead, the method should be static.
Attachment #776036 - Flags: review?(hv1989)
Comment on attachment 776036 [details] [diff] [review]
Make supportsFloatingPoint a static function.

Review of attachment 776036 [details] [diff] [review]:
-----------------------------------------------------------------

I see no downside to this.
Attachment #776036 - Flags: review?(hv1989) → review+
Keywords: checkin-needed
I've been trying to land this patch for something like three days, but the tree is perpetually closed. Trying with checkin-needed instead.
Attachment #776036 - Attachment is obsolete: true
Attachment #778076 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f74c23e8686

and no: even in Europe it's not easy to land things, nowadays ...
Assignee: general → sstangl
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2f74c23e8686
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.