Closed Bug 868683 Opened 7 years ago Closed 7 years ago

Assert that immediate shift given to the ARM shift instructions is within range.

Categories

(Core :: JavaScript Engine, defect, minor)

ARM
All
defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: dougc, Assigned: dougc)

Details

Attachments

(1 file)

To help catch programming errors, assert that immediate shift given to the ARM shift instructions is within range.
I made this error and perhaps the checks would help others detect programming errors.
Attachment #745463 - Flags: review?(mrosenberg)
Comment on attachment 745463 [details] [diff] [review]
Assert that the immediate shift given to the ARM shift instructions is within range.

Review of attachment 745463 [details] [diff] [review]:
-----------------------------------------------------------------

looks useful.
Attachment #745463 - Flags: review?(mrosenberg) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8e98863ce994

Should this have a test?
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
> https://hg.mozilla.org/mozilla-central/rev/8e98863ce994
> 
> Should this have a test?

The patch did not address any bugs that had landed, just
my own programming error in the use of the ARM shift
instructions.  The error did show up in the jit-tests,
but having the assertion checks makes it easier to
locate such problems.
You can just set the flag when the answer is no :P
Flags: in-testsuite? → in-testsuite-
You need to log in before you can comment on or make changes to this bug.