Last Comment Bug 868683 - Assert that immediate shift given to the ARM shift instructions is within range.
: Assert that immediate shift given to the ARM shift instructions is within range.
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: ARM All
: -- minor (vote)
: mozilla23
Assigned To: Douglas Crosher [:dougc]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-03 18:35 PDT by Douglas Crosher [:dougc]
Modified: 2013-05-06 18:01 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Assert that the immediate shift given to the ARM shift instructions is within range. (1.42 KB, patch)
2013-05-03 18:44 PDT, Douglas Crosher [:dougc]
marty.rosenberg: review+
Details | Diff | Review

Description Douglas Crosher [:dougc] 2013-05-03 18:35:04 PDT
To help catch programming errors, assert that immediate shift given to the ARM shift instructions is within range.
Comment 1 Douglas Crosher [:dougc] 2013-05-03 18:44:50 PDT
Created attachment 745463 [details] [diff] [review]
Assert that the immediate shift given to the ARM shift instructions is within range.

I made this error and perhaps the checks would help others detect programming errors.
Comment 2 Marty Rosenberg [:mjrosenb] 2013-05-03 23:38:17 PDT
Comment on attachment 745463 [details] [diff] [review]
Assert that the immediate shift given to the ARM shift instructions is within range.

Review of attachment 745463 [details] [diff] [review]:
-----------------------------------------------------------------

looks useful.
Comment 3 Ryan VanderMeulen [:RyanVM] 2013-05-06 06:06:13 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e98863ce994
Comment 4 Ryan VanderMeulen [:RyanVM] 2013-05-06 11:41:21 PDT
https://hg.mozilla.org/mozilla-central/rev/8e98863ce994

Should this have a test?
Comment 5 Douglas Crosher [:dougc] 2013-05-06 16:37:33 PDT
(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
> https://hg.mozilla.org/mozilla-central/rev/8e98863ce994
> 
> Should this have a test?

The patch did not address any bugs that had landed, just
my own programming error in the use of the ARM shift
instructions.  The error did show up in the jit-tests,
but having the assertion checks makes it easier to
locate such problems.
Comment 6 Ryan VanderMeulen [:RyanVM] 2013-05-06 18:01:03 PDT
You can just set the flag when the answer is no :P

Note You need to log in before you can comment on or make changes to this bug.