Assert that immediate shift given to the ARM shift instructions is within range.

RESOLVED FIXED in mozilla23

Status

()

Core
JavaScript Engine
--
minor
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dougc, Assigned: dougc)

Tracking

Trunk
mozilla23
ARM
All
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
To help catch programming errors, assert that immediate shift given to the ARM shift instructions is within range.
(Assignee)

Comment 1

4 years ago
Created attachment 745463 [details] [diff] [review]
Assert that the immediate shift given to the ARM shift instructions is within range.

I made this error and perhaps the checks would help others detect programming errors.
Attachment #745463 - Flags: review?(mrosenberg)
Comment on attachment 745463 [details] [diff] [review]
Assert that the immediate shift given to the ARM shift instructions is within range.

Review of attachment 745463 [details] [diff] [review]:
-----------------------------------------------------------------

looks useful.
Attachment #745463 - Flags: review?(mrosenberg) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e98863ce994
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8e98863ce994

Should this have a test?
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
(Assignee)

Comment 5

4 years ago
(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
> https://hg.mozilla.org/mozilla-central/rev/8e98863ce994
> 
> Should this have a test?

The patch did not address any bugs that had landed, just
my own programming error in the use of the ARM shift
instructions.  The error did show up in the jit-tests,
but having the assertion checks makes it easier to
locate such problems.
You can just set the flag when the answer is no :P
Flags: in-testsuite? → in-testsuite-
You need to log in before you can comment on or make changes to this bug.