868699 - XML Parsing Error on UX branch start

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

I think this is only a day or so old, but I just ran the UX Nightly on Ubuntu, and got the yellow screen of death, with:

XML Parsing Error: no element found Location: chrome://browser/content/browser.xul Line Number 2799, Column 1:

I've got a patch that fixes this - coming right up.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1.1

This was a case of an unclosed #ifdef caused by bug 865374.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

I went ahead and landed this with r=bustage-fix, since it was a pretty trivial bug.

Landed on UX as https://hg.mozilla.org/projects/ux/rev/f1c4c4ac8a36

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Pushed to Jamun as https://hg.mozilla.org/projects/jamun/rev/f1c4c4ac8a36

Comment 5

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/f1c4c4ac8a36

Comment 6

[Manuela Muntean [Away]]

I couldn't reproduce this issue with the UX build from ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/05/2013-05-02-04-02-02-ux/ on Ubuntu 13.10 32-bit.

I don't get the yellow screen of death when opening the UX build, and neither when opening a XML file in the browser. Also, I don't see any errors in the console.

I've also tried the above scenarios with Firefox 28 beta 1, and all looks good there, too.

Does anyone have a testcase to reproduce this, or any other suggestions/thoughts?

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Hey Manuela - it sounds like you've tried the primary scenario - the XML parsing error was occurring on start-up when Gecko attempted to parse the XUL markup for the browser UI.

So I think we're good here.

Comment 8

[Manuela Muntean [Away]]

Verified as fixed based on comment 6 and comment 7. Thanks Mike!