Add browser/app tree to dumbmake-dependencies

RESOLVED FIXED in mozilla23

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: Felipe, Assigned: Felipe)

Tracking

unspecified
mozilla23
All
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 745724 [details] [diff] [review]
browser/app dependencies

This adds the main toplevel/toplevel-like folders that needs browser/app to be rebuilt for Mac OS X (which generates the .app bundle). Basically any folder which has a jar.mn or .jsm files which go into omni.ja needs this, but I haven't included some rarely used ones for brevity.

I'm not sure if the idea is to make this work for every subfolder or just for top-level folders, but the way things work now I'd need to list every buildable subfolder to make it work. (I haven't included them on this patch) E.g.

`mach build browser/devtools` works, but
`mach build browser/devtools/webconsole` doesn't

Same goes for browser/themes/*, toolkit/components/*, etc.

In any case, this is a good start.

Also, I haven't checked if browser/app is a no-op or close to a no-op on linux/win. We should verify that before landing this.
Attachment #745724 - Flags: review?
(Assignee)

Comment 1

5 years ago
Created attachment 745725 [details] [diff] [review]
browser/app dependencies

(leftover debug on previous patch, sigh)

Flagging gps for review but if people frequently working on browser/ or toolkit/ js code wants to chime in, please do
Attachment #745725 - Flags: review?(gps)
(Assignee)

Updated

5 years ago
Attachment #745724 - Attachment is obsolete: true
Attachment #745724 - Flags: review?

Comment 2

5 years ago
Comment on attachment 745725 [details] [diff] [review]
browser/app dependencies

Review of attachment 745725 [details] [diff] [review]:
-----------------------------------------------------------------

This is 95% rubber stamp.
Attachment #745725 - Flags: review?(gps) → review+
> `mach build browser/devtools` works, but
> `mach build browser/devtools/webconsole` doesn't
> 
> Same goes for browser/themes/*, toolkit/components/*, etc.

We could teach |mach build browser/devtools/webconsole| a little about paths.  For example, it could so if it has extra dependencies for browser/devtools/webconsole, then browser/devtools, then browser/.  The logical next step is /, at which you're doing a full build, so I don't think this is actually worth it -- but perhaps others know better.
(Assignee)

Comment 4

5 years ago
I removed the `browser` entry in the list before landing because building browser will already build browser/app, but it's interesting that there are other similar cases in the tree, e.g.

  docshell/build
    docshell

afaict building docshell will build docshell/build anyways

https://hg.mozilla.org/integration/mozilla-inbound/rev/cfb9005d13e2
https://hg.mozilla.org/mozilla-central/rev/cfb9005d13e2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.