Closed
Bug 868974
Opened 13 years ago
Closed 11 years ago
puppetagain: support master randomization within classes
Categories
(Infrastructure & Operations :: RelOps: Puppet, task)
Infrastructure & Operations
RelOps: Puppet
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dustin, Unassigned)
Details
(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1284] )
Attachments
(1 file)
|
10.91 KB,
patch
|
rail
:
review+
dustin
:
checked-in+
|
Details | Diff | Splinter Review |
The idea is this: each agent determines which "class" it is in (based, initially, on location). It then creates its list of masters as follows:
* all masters in the same class, in random order
* all remaining masters, in random order without regard to class
It uses the first master in its list as its "main" master.
This will support the kind of randomization AWS needs - each AZ will be a "class". It will also support hosting multiple puppetmasters in scl3 when the time comes.
|
Reporter | |
Comment 1•13 years ago
|
||
This should allow proper randomization in AWS, and also allow us to expand scl3 to multiple masters when that becomes necessary. This is for the puppet320 repo.
Attachment #746037 -
Flags: review?(rail)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 746037 [details] [diff] [review]
bug868974.patch
dustin, I'm unable to apply this patch. Can you rebase it?
|
|
Reporter | |
Comment 3•13 years ago
|
||
Did you apply it to the puppet320 repo (http://hg.mozilla.org/users/dmitchell_mozilla.com/puppet320/)
|
|
||
Comment 4•13 years ago
|
||
Comment on attachment 746037 [details] [diff] [review]
bug868974.patch
(In reply to Dustin J. Mitchell [:dustin] from comment #3)
> Did you apply it to the puppet320 repo
> (http://hg.mozilla.org/users/dmitchell_mozilla.com/puppet320/)
Ah, no. The patch itself looks good to me.
Attachment #746037 -
Flags: review?(rail) → review+
|
|
Reporter | |
Updated•13 years ago
|
Attachment #746037 -
Flags: checked-in+
|
|
Reporter | |
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 5•13 years ago
|
||
This shuffling does not appear to be stable :(
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Reporter | |
Comment 6•13 years ago
|
||
I must have been imagining things. It seems stable on all of the foopies.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 7•12 years ago
|
||
Not really. I need to dig into this more. My impression is that the ordering changes when you use an environment, but it may be even more than that. Needs a good hard look.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Updated•12 years ago
|
Component: Server Operations: RelEng → RelOps: Puppet
Product: mozilla.org → Infrastructure & Operations
QA Contact: arich → dustin
|
|
Reporter | |
Updated•12 years ago
|
Severity: normal → enhancement
|
|
Reporter | |
Updated•12 years ago
|
Assignee: dustin → relops
Severity: enhancement → normal
|
|
||
Updated•11 years ago
|
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/404]
|
|
||
Updated•11 years ago
|
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/404] → [kanban:engops:https://kanbanize.com/ctrl_board/6/411]
|
|
||
Updated•11 years ago
|
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/411]
|
|
||
Updated•11 years ago
|
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/502]
|
|
||
Updated•11 years ago
|
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/502] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1273] [kanban:engops:https://kanbanize.com/ctrl_board/6/502]
|
|
||
Updated•11 years ago
|
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1273] [kanban:engops:https://kanbanize.com/ctrl_board/6/502] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1278] [kanban:engops:https://kanbanize.com/ctrl_board/6/502]
|
|
||
Updated•11 years ago
|
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1278] [kanban:engops:https://kanbanize.com/ctrl_board/6/502] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1280] [kanban:engops:https://kanbanize.com/ctrl_board/6/502]
|
|
||
Updated•11 years ago
|
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1280] [kanban:engops:https://kanbanize.com/ctrl_board/6/502] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1284] [kanban:engops:https://kanbanize.com/ctrl_board/6/502]
|
||
Updated•11 years ago
|
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1284] [kanban:engops:https://kanbanize.com/ctrl_board/6/502] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1284]
|
|
Reporter | |
Comment 8•11 years ago
|
||
From everything I can tell, this is some kind of puppet bug -- probably to do with environments. It doesn't cause any actual problems.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•