86899 - Send this email address as anonymous FTP password is not greyed out when box is unchecked

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect)

Description

[André Dahlqvist]

[Tested with Build 2001-06-20-17 on Linux, but this has been here for ages]

The textbox under the label "Send this email address as anonymous FTP password",
under Advanced in Preferences, is not greyed out when the checkbox is unchecked.
It is read-only, but it should also be grayed out to clearly show that text
cannot be typed into it.

Steps to reproduce:

1) Open Preferences and click on the Advanced category

2) Check and uncheck the anonymous FTP password checkbox

Result: The textbox is not "greyed out" when the checkbox is unchecked.

Expected result: Apart from being read-only (which it is) the textbox should
also be greyed out to indicate that text cannot be typed into it.

Comment 1

[sairuh (rarely reading bugmail)]

also see this on winnt and mac, as well as both themes.

not sure who should get this...trying blake for now.

as tangent, in the Mail and Newgroups toplevel panel, there's a similar
situation when you deselect the "When mail launches, show the Start Page..."
checkbox: the Location textfield isn't disabled. the difference, however, is
that the Location textfield here is editable. jglick/nbaca, i'm just curious,
but is that field supposed to be editable even if the checkbox is not checked?

Comment 2

[jglick]

>is that field supposed to be editable even if the checkbox is not checked?

sairuh, I believe you are correct, text field should be disabled if checkbox is 
unchecked.

Comment 3

[sairuh (rarely reading bugmail)]

filed bug 86986 for the Mailnews pref panel issue.

Comment 4

[André Dahlqvist]

Could someone explain to me why the below patch makes a difference? Note: the
extra "field.disabled = !checked;" oddly enough needs to be there, otherwise the
textbox will be non-editable even when it's not greyed out.

Also note that the initial state of the textbox and checkbox seams to be wrong,
so you have to click on the checkbox twise to see the textbox's state change.

I know this patch is probably not of much help, but at least it shows what code
needs to be changed.

Index: pref-advanced.xul
===================================================================
RCS file:
/cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-advanced.xul,v
retrieving revision 1.54
diff -u -r1.54 pref-advanced.xul
--- pref-advanced.xul   2001/06/20 05:51:44     1.54
+++ pref-advanced.xul   2001/06/21 10:44:07
@@ -46,6 +46,10 @@
     {
       var checked = document.getElementById("advancedMailFTP").checked;
       var field = document.getElementById("advancedMailFTPAddress");
+      if (checked)
+        field.setAttribute("disabled", "false");
+      else
+        field.setAttribute("disabled", "true");
       field.disabled = !checked;
     }

Comment 5

[Blake Ross]

Attachment: patch

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

sr=[e-mail]

Comment 7

[Jason Kersey]

r=kerz

Comment 8

[André Dahlqvist]

I just tried this patch on top of 2001-06-22-00 and it worked exactly as
expected. Thanks Blake!

Comment 9

[[e-mail]]

Please don't apply this fix. It doesn't resolve the actual problem which is that
the disabled property doesn't make the textbox appear disabled.

The disabled property is proxied on to the internal html input which then sets
the disabled attribute on itself. It is this that should be styled in the skins.

Comment 10

[[e-mail]]

Or the disabled attribute should be set by the property as well as being proxied.

Comment 11

[Blake Ross]

I already checked it in.

Yes, I know you could take either approach -- style based on the state of the 
anonymous input, or just set the attribute in the property getter/setter (both 
seems like overkill).  I asked Ben beforehand, and he said to just set the 
property.

Comment 12

[[e-mail]]

So this means that every time that someone wants to disable a textbox they have
to do it twice?

Comment 13

[Blake Ross]

No, why would it mean that?  It means that you can use .disabled or 
setAttribute("disabled", "true") and the styling will be correct.

Comment 14

[[e-mail]]

Sorry for all the spam caused entirely by a misunderstanding on my part.

Comment 15

[Blake Ross]

I checked this in.

Comment 16

[sairuh (rarely reading bugmail)]

trunk-only fix. vrfy'd fixed using 2001.07.11.xx-trunk comm bits on linux, winnt
and mac [and both themes, just to be sure].