869033 - [socorro-crashstats] build_id in forms.py should be a more picky field

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Peter Bengtsson [:peterbe]]

The field "Build ID" on the Advanced Filters form allows any kind of input (it's a CharField at the time of writing). It should only allow input values that look like actual Build IDs.

Comment 1

[Peter Bengtsson [:peterbe]]

As an implementation note; I suggest we make a custom BuildIDField class and use that.

Comment 3

[Peter Bengtsson [:peterbe]]

Ping! This is still bother stephend's test automation. 

The keep coming in 
https://errormill.mozilla.org/webtools/socorro-crashstats-dev/group/15914/

What we need to do is catch it with validation so it never attempts to contact the middleware when the build_ids is a url looking string.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/4b1f144a4cdabc971700dd2bc865d8a49d51c6f4
Fixes bug 869033 - Made build_id a more picky field. r=peterbe

https://github.com/mozilla/socorro-crashstats/commit/820bde03334c777500cf1fca8f137130749c49f6
Merge pull request #352 from AdrianGaudebert/869033-build-id-field

Fixes bug 869033 - Made build_id a more picky field.