Closed Bug 869050 Opened 7 years ago Closed 7 years ago

Update anonid and classname for tristate-menulist

Categories

(Toolkit :: Add-ons Manager, defect)

23 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file, 2 obsolete files)

The current tristate-menulist for plugins has a weird name and wouldn't match anymore when more than tree options are available. Also to make it better accessible it should get an update to its anonid and class name.

From bug 865640 comment #22:
>> Why can't it simply be state-menulist? Beside that we could also update the
>> class to 'addon-control state' to be in sync with the other buttons (enable,
>> disable, ...). So we could grab the element via the class.
>
> Yep, both of those suggestions sound reasonable - happy to r+ a patch that
> did that.
> 
> (Just so you're aware, the UI for this may be changing sometime in the
> future - the current usage of a menulist was a bit of a compromise to get
> this shipped quickly. No ETA on when that may happen though.)

This has been introduced with the patch on bug 549697.
Summary: Update → Update anonid and classname for tristate-menulist
Attached patch Patch v1.1 (obsolete) — Splinter Review
The try server tests failed because I missed to change an instance of detail-tristate-menulist in the extensions.js file. After that fix it works fine locally. Blair, if you want another try server run before it's landing please let me know. Otherwise here my local results:

 1:28.33 INFO TEST-START | Shutdown
 1:28.33 Browser Chrome Test Summary
 1:28.34 	Passed: 6523
 1:28.34 	Failed: 0
 1:28.34 	Todo: 0
 1:28.34 
 1:28.34 *** End BrowserChrome Test Results ***
Attachment #745922 - Attachment is obsolete: true
Attachment #745922 - Flags: review?(bmcbride)
Attachment #746011 - Flags: review?(bmcbride)
Attachment #746011 - Flags: review?(bmcbride) → review+
Attached patch Patch v1.2Splinter Review
Updated patch for check-in due to conflicts in applying because of latest changes in extensions.xml.
Attachment #746011 - Attachment is obsolete: true
Attachment #746265 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/74212adbe306
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.