Closed
Bug 869072
Opened 11 years ago
Closed 11 years ago
Debug check in MacroAssembler-x64.h is ineffective
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: sunfish, Unassigned)
Details
Attachments
(1 file)
|
1.63 KB,
patch
|
sstangl
:
review+
|
Details | Diff | Splinter Review |
The debug check here: http://hg.mozilla.org/mozilla-central/file/ee5ca214e87c/js/src/ion/x64/MacroAssembler-x64.h#l211 is checking for BelowOrEqual a 64-bit all-ones value, since the Imm32 creates a signed immediate value. This condition is always true. I attempted to fix this by loading the immediate into the scratch register, but that seems to cause problems, so I don't have a suggestion of how to fix this.
|
||
Comment 1•11 years ago
|
||
|dest| can be used as a scratch register if |movq| is moved to after the #endif.
|
Reporter | |
Comment 2•11 years ago
|
||
Thanks. The attached patch implements that, and fixes the bug.
Attachment #748966 -
Flags: review?(sstangl)
|
|
||
Updated•11 years ago
|
Attachment #748966 -
Flags: review?(sstangl) → review+
|
|
||
Updated•11 years ago
|
Whiteboard: checkin-needed
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ffd8124e903c
Whiteboard: checkin-needed
|
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ffd8124e903c
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•