Closed Bug 869273 Opened 7 years ago Closed 7 years ago

PhoneNumberJS: Handle countries without format string correctly.

Categories

(Core :: DOM: Device Interfaces, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23
blocking-b2g tef+
Tracking Status
firefox21 --- wontfix
firefox22 --- wontfix
firefox23 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- fixed

People

(Reporter: gwagner, Assigned: reuben)

References

Details

(Whiteboard: [fixed-in-birch])

Attachments

(1 file)

I wrote a small fuzzer for PhonenumberJS and it currently throws for:
01082, FK
07466, KI
And some more:
01102,TV,97210,TV,22053,KI,0909,NU,772665,TV,68623687,DO,2476975,BS,636542,TV,6004,AC,04926,IL,01990,FK,04160,TV,063344,TV,1818,NU,26280,KI,17034302,GI,1418,SH,75975,KI,96449,TV,0928,TK,2908987,NE,27841244,GI,25950,KI,0753,NU,0566,TK,10228,FK,79893169,GI,9145,NU,2122,TK,070841,TV,2921,SH,89904160,GI,89982,FK,58005,TV,6902794,TZ,48929,FK,+2906146,ML,539016,TV,11104,KI,1430,SH,612479,TV,0545,TK,4205,NU,782443,TV,4665,TK,046349,KI,83014617,GI,9103,AC,02946,FK,85288,KI,47713,FK,6486,TK,9103,SH,2121,AC,61031009,GI,7784,AC,96815,KI,51921,FK,68822140,GL,26828,FK,81684,FK,82051,FK,53531352,GI,0421,SH,06592811,GI,71844924,GI,48336,FK,04657273,GI,04286074,GI,90991,FK,77021,KI,7840,SH,2416,TK,88084,TV,6835,TK,52367,FK,25116,TV,2984,TK,23094,TV,12230,KI,757336,TV,6712,IL,420484,TV,6831397,GH,0201,SH,4132,IL,3388,TK,116472,TV,07615626,GI,85157,TV,2259,SH,0937,NU,3228,IL,36630,KI,8136,SH,81273794,GI,073117,TV,7679,SH,7512,TK,4361,IL,0180,SH,33041,FK,464709,TV,04687,IL,363294,TV,99404982,GI,6960,NU,03639,IL,81585,FK,0785,NU,9324,AC,68641498,VU,2906835,CI,6976,IL,91672,KI,255411,TV,2909385,KY,6904871,BB,0720,TK,09916728,GI,9724999,MR,4077,SH,67836,FK,72236112,GI,02069,FK,5039,SH,63760,TV,2907344,MW,63314,FK,03697,IL,01051,KI,99482,TV,58205,TV,045077,TV,43111,KI,2560,AC,95665,FK,91636,KI,096722,TV,2908997,US,50040493,FR,0384,TK,644197,TV,34732,KI,5838,NU,6389,AC,3590,TK,7899,SH,50077390,GQ,7173,SH,04204,TV,2546,SH,01433234,GI,36879,FK,05564,TV,278029,TV,72629,KI,54044,TV,41310,TV,5146,SH,3206,AC,03672,FK,4587,AC,3858,IL,38697,KI,0161,SH,321733,TV,7815,NU,6462,NU,87677022,GI,01724,FK,0418,SH,8753,SH,7345,TK,275366,TV,9911,TK,2504,NU,03102,IL,9722421,IQ,66693,FK,9854,AC,62210,TV,8430,AC,9106,TK,3360,NU,06483669,GI,38266,TV,1294,SH,2025,AC,48709,FK,46323614,GI,73718210,GI,02097674,GI,52418,FK,10404259,GI,6642,SH,1237,SH,07531,TV,8898,SH,97169,KI,07907,KI,75643181,GI,29738,TV,9169,AC,69613944,GI,71186,KI,018265,TV,3417,IL,6450,NU,64500882,GI,3309,TK,404251,TV,09121,FK,2283,AC,1360,NU,352696,TV,5683,AC,+68899836,NG,4858,NU,11339,TV,4067,SH,68824227,TR,6035,SH,55877,FK,0853,TK,85776891,GI,47248,TV,4681,IL,08127,FK,6301,NU,6519,AC,733917,TV,12561,KI,68827484,GP,56963,KI,6099,IL,+50060710,PY,35020669620,TN,76658972,GI,0196,AC,8656,TK,6903417,GL,811253,TV
Assignee: nobody → reuben.bmo
Attachment #746630 - Flags: review?(anygregor)
Attachment #746630 - Flags: review?(anygregor) → review+
https://hg.mozilla.org/projects/birch/rev/b9eaf9703cbd

[leave open] in case we find more of those in the future.
Whiteboard: [fixed-in-birch][leave open]
(In reply to Reuben Morais [:reuben] from comment #3)
> https://hg.mozilla.org/projects/birch/rev/b9eaf9703cbd
> 
> [leave open] in case we find more of those in the future.

Lets close it and file a new one if we find more.
Summary: PhoneNumberJS: Fuzzer bugs → PhoneNumberJS: Handle countries without format string correctly.
Whiteboard: [fixed-in-birch][leave open] → [fixed-in-birch]
https://hg.mozilla.org/mozilla-central/rev/b9eaf9703cbd
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Blocks: 860836
This could have the same outcome as bug 860836.
blocking-b2g: --- → tef?
Safe fix, let's uplift.
blocking-b2g: tef? → tef+
Comment on attachment 746630 [details] [diff] [review]
Update Gecko's copy of PhoneNumber.js

Andreas can you do some sanity check?
Attachment #746630 - Flags: review?(gal)
Attachment #746630 - Flags: review?(gal)
You need to log in before you can comment on or make changes to this bug.