869357 - ./mach empty-makefiles fails on intl/icu/source/data/Makefile.in

Status: RESOLVED DUPLICATE of bug 980174

(Firefox Build System :: General, defect)

Description

[Mark Banner (:standard8)]

Running ./mach empty-makefiles is failing with:

Error running mach:

    ['empty-makefiles']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

SyntaxError: /Users/moztest/comm/main/src/mozilla/intl/icu/source/data/Makefile.in:486:38:order-only prerequisites not implemented

  File "/Users/moztest/comm/main/src/mozilla/python/mozbuild/mozbuild/mach_commands.py", line 544, in empty
    statements = [s for s in pymake.parser.parsefile(path)
  File "/Users/moztest/comm/main/src/mozilla/build/pymake/pymake/parser.py", line 373, in parsefile
    return _parsecache.get(pathname)
  File "/Users/moztest/comm/main/src/mozilla/build/pymake/pymake/util.py", line 136, in get
    item.o = self.cfunc(key)
  File "/Users/moztest/comm/main/src/mozilla/build/pymake/pymake/parser.py", line 351, in _parsefile
    stmts = parsestring(fd.read(), pathname)
  File "/Users/moztest/comm/main/src/mozilla/build/pymake/pymake/parser.py", line 592, in parsestring
    raise SyntaxError('order-only prerequisites not implemented', d.getloc(offset))

Comment 1

[Mark Banner (:standard8)]

This is an imported library afaict.

Comment 2

[Mark Banner (:standard8)]

The empty-makefiles no longer works (see below). Is it worth a bug to restore that functionality, or should we just drop it now?

The details of the failure are as follows:

ImportError: No module named pymake.parser

  File "/Users/mark/loop/fx-team-git/python/mozbuild/mozbuild/mach_commands.py", line 1224, in empty
    import pymake.parser
  File "/Users/mark/loop/fx-team-git/build/mach_bootstrap.py", line 366, in __call__
    module = self._original_import(name, globals, locals, fromlist, level)

Comment 3

[Mike Hommey [:glandium]]

It's just missing build/pymake in the SEARCH_PATHS in build/mach_bootstrap.py.

Comment 4

[Mike Hommey [:glandium]]

Incidentally, the bug as originally reported was fixed in bug 980174

Comment 5

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #3)
> It's just missing build/pymake in the SEARCH_PATHS in
> build/mach_bootstrap.py.

erf, I removed it in bug 1151124.