869383 - [customize]Can't open homescreen with firefox nightly profile while make with HIDPI=1

Status: RESOLVED FIXED

Description

[[e-mail]]

while make with 

 $ HIDPI=1 DEBUG=1 make

and start firefox nightly with 

 $ /Application/firefox -profile /user_path/gaia/profile

Homescreen can not be opened as usual.

Comment 1

[[e-mail]]

I found in Makefile:'profile/settings.json' section

It run python build/settings.py twice to generate settings.json

I think the first one is redundant.
Is there any particular reason to do that?

Comment 2

[[e-mail]]

Created attachment 749677 [details]
pull request redirect to github

The --hidpi not pass param to settings.py, which cause weird result that can't be parsed correctly.

remove it because pass correspondent --wallpaper to settings.py is sufficient to do the HIDPI work in settings.py

Comment 3

[[e-mail]]

merged to master-gaia c51c8b38558fd82216ef8220368bd63cefc50322
thanks!

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

It seems that the root cause is that there is an extra ":" before $(GAIA_PORT)?

==
ifeq ($(DEBUG),1)
  SETTINGS_ARG += --homescreen=http://homescreen.$(GAIA_DOMAIN):$(GAIA_PORT)/manifest.webapp
endif
==

This issue would only occur when trying to run the following line, because "--homescreen" would be regarded as the parameter for "--hidpi", which will not override the settings in $(SETTINGS_ARG).

"python build/settings.py $(SETTINGS_ARG) --hidpi --homescreen $(SCHEME)homescreen.$(GAIA_DOMAIN)$(GAIA_PORT)/manifest.webapp"

Comment 5

[[e-mail]]

I think remove ':' as $(GAIA_DOMAIN)$(GAIA_PORT) will lead to address like 'http://192.168.1.18080' instead of 'http://192.168.1.1:8080', which is not the correct URL

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

However, the default for GAIA_PORT is defined with ":",
GAIA_PORT?=:8080

That's why we got an extra ":" here, i.e.,
  SETTINGS_ARG += --homescreen=http://homescreen..gaiamobile.org::8080/manifest.webapp

Thanks.

Comment 7

[[e-mail]]

Rudy, Nice catch! 
Though the current patch works and it might not worth to fire another issue to solve that independently.

needinfo? kevin, would you mind give a favor to remove ':'$(GAIA_PORT) described in comment 6 while you do other desktop-helper change?

Comment 8

[[e-mail]]

nominate to upport preview screen in nightly
need uplift this patch to HD branch

Comment 9

[Kevin Grandon :kgrandon]

Created attachment 765190 [details]
Github pull request pointer

I was curious so was poking around. Not sure if you still need this, but here's a pull request anyway.

Comment 10

[James Lal [:lightsofapollo]]

Created attachment 765193 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10497

Pointer to Github pull-request

Comment 11

[[e-mail]]

Comment on attachment 765190 [details]
Github pull request pointer

kevin thanks for the favor, 
originally I'd expect its a minor issue that not need to fix independently.

Comment 12

[Kevin Grandon :kgrandon]

True, but I'm sure we would've forgotten about it :)

Landed in master here: https://github.com/mozilla-b2g/gaia/commit/dbc7647607166ae731c55a7d4c2bc878e0dfb231

Comment 13

[[e-mail]]

Just check v1.1.0hd Makefile, it has changed to GAIA_DEV_PIXELS_PER_PX base, so its not relevant to this issue though