Last Comment Bug 869425 - Move MODULE to moz.build in comm-central
: Move MODULE to moz.build in comm-central
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: Thunderbird 23.0
Assigned To: Joshua Cranmer [:jcranmer]
:
Mentors:
Depends on: 844654
Blocks: 864191
  Show dependency treegraph
 
Reported: 2013-05-07 06:39 PDT by Joshua Cranmer [:jcranmer]
Modified: 2013-05-09 10:15 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Move MODULE definitions to moz.build (105.04 KB, patch)
2013-05-07 10:42 PDT, Joshua Cranmer [:jcranmer]
standard8: review+
Details | Diff | Splinter Review
Kill now-empty makefiles (13.20 KB, patch)
2013-05-07 10:43 PDT, Joshua Cranmer [:jcranmer]
standard8: review+
Details | Diff | Splinter Review

Description Joshua Cranmer [:jcranmer] 2013-05-07 06:39:46 PDT

    
Comment 1 Joshua Cranmer [:jcranmer] 2013-05-07 10:42:10 PDT
Created attachment 746511 [details] [diff] [review]
Move MODULE definitions to moz.build

I don't think all of these MODULE definitions are necessary, but I didn't look too hard to see which weren't needed. I did merge XPIDL_MODULE and MODULE definitions that were the same.
Comment 2 Joshua Cranmer [:jcranmer] 2013-05-07 10:43:03 PDT
Created attachment 746512 [details] [diff] [review]
Kill now-empty makefiles

As our Makefile.in count starts its slow journey to the number 0...
Comment 3 Mark Banner (:standard8) 2013-05-08 01:46:43 PDT
Comment on attachment 746511 [details] [diff] [review]
Move MODULE definitions to moz.build

diff --git a/mail/components/search/moz.build b/mail/components/search/moz.build
+    MODULE = 'mailwinsearch'
+

No indent necessary.

Note You need to log in before you can comment on or make changes to this bug.