869497 - Remove function expression names from the debugger, netmonitor and widgets

Status: RESOLVED FIXED

(DevTools :: General, defect, P3)

Description

[Victor Porof [:vporof][:vp]]

REDUNDUNDANT.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Victor Porof [:vporof][:vp]]

Green: https://tbpl.mozilla.org/?tree=Try&rev=6dcc1c0f1ecc

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 746584 [details] [diff] [review]
v1

Review of attachment 746584 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/debugger/CmdDebugger.jsm
@@ +109,5 @@
>        "      <span class='gcli-out-shortcut'" +
>        "            data-command='break del ${breakpoint.index}'" +
>        "            onclick='${onclick}'" +
> +      "            ondblclick='${ondblclick}'>" +
> +      "        " + gcli.lookup("breaklistOutRemove") + "</span>" +

character shuffling?

@@ +144,3 @@
>            let dbg = getPanel(context, "jsdebugger");
>            if (dbg) {
> +            return dbg.panelWin.DebuggerView.Sources.values;

++

::: browser/devtools/debugger/DebuggerUI.jsm
@@ +173,5 @@
>   *        The parent instance creating the new debugger.
>   * @param XULElement aTab
>   *        The tab in which to create the debugger.
>   */
> +this.DebuggerPane = function DebuggerPane(aDebuggerUI, aTab) {

why bother with this? The previous is essentially the same, putting DebuggerPane on the local global context.

@@ +304,5 @@
>   *
>   * @param DebuggerUI aDebuggerUI
>   *        The parent instance creating the new debugger.
>   */
> +this.RemoteDebuggerWindow = function RemoteDebuggerWindow(aDebuggerUI) {

ditto.

::: browser/devtools/debugger/debugger-controller.js
@@ +4,5 @@
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  "use strict";
>  
> +const { classes: Cc, interfaces: Ci, utils: Cu } = Components;

this is what we've become.

Comment 4

[Rob Campbell [:rc] (:robcee)]

very well. let them all rebase.

Comment 5

[Victor Porof [:vporof][:vp]]

Rebased (oh the irony) and landed: https://hg.mozilla.org/integration/fx-team/rev/c7a70d12c122

Comment 6

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/mozilla-central/rev/c7a70d12c122