869536 - Force Marionette to use its own tab unless switch_to_window() is called.

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Jonathan Griffin (:jgriffin)]

We frequently use getMostRecentWindow() in marionette-actors.js in order to target the topmost window, but this can be unreliable (see bug 838607).  Instead, we should force Marionette to use the tab which it opens, unless switch_to_window() is used.

Comment 2

[Jonathan Griffin (:jgriffin)]

Attachment: Make Marionette use its own tab on Firefox,

This solves the problem of identifying Marionette's frame by url ('about:blank'); when using the url, we were sometimes attaching to the wrong frame because other tabs will have an 'about:blank' url for a short time before their content (like the home page) is loaded.

We were already doing the right thing in getCurrentWindow...we were returning the current browser's window unless we didn't have a current browser.

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 750768 [details] [diff] [review]
Make Marionette use its own tab on Firefox,

Review of attachment 750768 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/marionette-actors.js
@@ +2361,2 @@
>     * @param string href
>     *        frame's href 

can you update this docstring?

Comment 4

[Jonathan Griffin (:jgriffin)]

Review comments addressed, landed as https://hg.mozilla.org/integration/mozilla-inbound/rev/c3b24901a518

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c3b24901a518

Comment 7

[Jonathan Griffin (:jgriffin)]

checkin-needed for mozilla-b2g18 and 1.0.1 please

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/adda2ea6d1d1
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/047b7010c99a