Closed Bug 869536 Opened 12 years ago Closed 12 years ago

Force Marionette to use its own tab unless switch_to_window() is called.

Categories

(Remote Protocol :: Marionette, defect)

defect
Not set
normal

Tracking

(firefox22 wontfix, firefox23 wontfix, firefox24 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)

RESOLVED FIXED
mozilla24
Tracking Status
firefox22 --- wontfix
firefox23 --- wontfix
firefox24 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- fixed

People

(Reporter: jgriffin, Assigned: jgriffin)

References

Details

Attachments

(1 file)

We frequently use getMostRecentWindow() in marionette-actors.js in order to target the topmost window, but this can be unreliable (see bug 838607). Instead, we should force Marionette to use the tab which it opens, unless switch_to_window() is used.
This solves the problem of identifying Marionette's frame by url ('about:blank'); when using the url, we were sometimes attaching to the wrong frame because other tabs will have an 'about:blank' url for a short time before their content (like the home page) is loaded. We were already doing the right thing in getCurrentWindow...we were returning the current browser's window unless we didn't have a current browser.
Attachment #750768 - Flags: review?(mdas)
Comment on attachment 750768 [details] [diff] [review] Make Marionette use its own tab on Firefox, Review of attachment 750768 [details] [diff] [review]: ----------------------------------------------------------------- ::: testing/marionette/marionette-actors.js @@ +2361,2 @@ > * @param string href > * frame's href can you update this docstring?
Attachment #750768 - Flags: review?(mdas) → review+
Target Milestone: --- → mozilla24
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
checkin-needed for mozilla-b2g18 and 1.0.1 please
Keywords: checkin-needed
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: