If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove the .cvsignore files

RESOLVED FIXED in 3.15

Status

NSS
Libraries
P2
trivial
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Wan-Teh Chang, Assigned: Wan-Teh Chang)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Created attachment 746566 [details] [diff] [review]
Remove the .cvsignore files in nss/cmd and nss/lib

There are a few .cvsignore files in the NSS source tree.
I divide them into three groups:

  nss/cmd/.cvsignore
  nss/lib/dbm/src/.cvsignore
  nss/lib/dbm/include/.cvsignore
  nss/lib/dbm/.cvsignore
  nss/lib/dbm/tests/.cvsignore
  nss/lib/certdb/.cvsignore

  nss/doc/html/.cvsignore
  nss/doc/.cvsignore

  nss/tests/pkcs11/netscape/trivial/.cvsignore

It should be fine to just remove the .cvsignore files in the first group.
The attached patch does that.

Elio, I'll need you to decide how to replace the .cvsignore files in
nss/doc.

The .cvsingore file in nss/tests/pkcs11 probably is not worth removing
separately. I think we should remove the entire nss/tests/pkcs11 directory.
Attachment #746566 - Flags: review?(bsmith)
Attachment #746566 - Flags: review?(bsmith) → review+
(Assignee)

Comment 1

4 years ago
Comment on attachment 746566 [details] [diff] [review]
Remove the .cvsignore files in nss/cmd and nss/lib

https://hg.mozilla.org/projects/nss/rev/018cd55949ef
Attachment #746566 - Flags: checked-in+

Comment 2

4 years ago
(In reply to Wan-Teh Chang from comment #0)
> 
> Elio, I'll need you to decide how to replace the .cvsignore files in
> nss/doc.

I don't see a reason for the ones nss/doc should be treated differently.

Comment 3

4 years ago
Created attachment 746655 [details] [diff] [review]
Remove .cvsignore files inside doc and doc/html
Attachment #746655 - Flags: review?(wtc)
(Assignee)

Comment 4

4 years ago
Comment on attachment 746655 [details] [diff] [review]
Remove .cvsignore files inside doc and doc/html

Review of attachment 746655 [details] [diff] [review]:
-----------------------------------------------------------------

r=wtc. We can always remove these first, and add .hgignore later
when Kai returns.

::: doc/.cvsignore
@@ -1,2 @@
> -date.xml
> -version.xml

Just wanted to make sure you don't need hg to ignore these files.

CVS history shows Kai was the person who added these .cvsignore
files. Perhaps Kai should also review this?
Attachment #746655 - Flags: superreview?(kaie)
Attachment #746655 - Flags: review?(wtc)
Attachment #746655 - Flags: review+

Comment 5

4 years ago
Ah. they are created each time in prepare phase when we build. I see that in the original git repo I forgot to to add them to a .gitignore, omission that Kai rectified by adding them to a .cvsignore when we moved the project to cvs. We then should replace doc/.cvsignore with a doc/.hgignore.  I don't understand the other one: $cat html/.cvsignore 
*.proc

Comment 6

4 years ago
I do now, after doing make build-docs, ls -a doc/html/*.proc shows me a *.proc files, one for each .html file generated.
(Assignee)

Comment 7

4 years ago
Elio: Good. If you know how to make hg ignore those files, you can
update your patch. Thanks.

Comment 8

4 years ago
Created attachment 746694 [details] [diff] [review]
rename .cvsignore to .hgignore on doc and doc/html

... and clean up generated .proc files
Attachment #746655 - Attachment is obsolete: true
Attachment #746655 - Flags: superreview?(kaie)
Attachment #746694 - Flags: review?(wtc)
(Assignee)

Comment 9

4 years ago
Comment on attachment 746694 [details] [diff] [review]
rename .cvsignore to .hgignore on doc and doc/html

Review of attachment 746694 [details] [diff] [review]:
-----------------------------------------------------------------

r=wtc.

You have a typo in the description of the patch: .gitignore => .hgignore

::: doc/Makefile
@@ +23,5 @@
>  	mkdir -p nroff
>  	
>  clean:
>  	rm -f date.xml version.xml *.tar.bz2
> +	rm -f html/*.proc

Just wanted to make sure this is also part of the patch.
Attachment #746694 - Flags: review?(wtc) → review+

Comment 10

4 years ago
I'm so used to think in terms of git. Yes, the cleaning up is part of the patch.

Updated

4 years ago
Attachment #746694 - Attachment description: rename .cvsignore to .gitignore on doc and doc/html → rename .cvsignore to .hgignore on doc and doc/html

Comment 11

4 years ago
Changes pushed to the tip for nss-3.15
https://hg.mozilla.org/projects/nss/rev/b610af8addaa
(Assignee)

Comment 12

4 years ago
Thank you, Elio.

Marked the bug fixed. The only remaining .cvsignore file is
nss/tests/pkcs11/netscape/trivial/.cvsignore. As I said above
I think we should just remove the entire nss/tests/pkcs11 directory.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: 3.15.1 → 3.15
You need to log in before you can comment on or make changes to this bug.