869617 - Change - Remove dropdown menu from start sections

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Firefox Start, defect, P2)

Description

[Allison Naaktgeboren :ally]

For legacy reasons (afaik) the panels are connected by a drop down menu. 

discussed on irc, mbrubeck is strongly in favor of removing the _menu_ (not the panels). I have no objection, but we should make sure there is no compelling ux/product reason to keep it.

Comment 1

[Jim Mathies [:jimm]]

requesting approval from yuan.

Comment 2

[Asa Dotzler [:asa]]

Yes, please remove the dropdowns for now. Those are part of the feature we've cut for v1.

Comment 3

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

I am okay with not having for V1, because the panel are not fully functional. 

But once we have fully functional panels, having a quick way to navigate through them could be convenient. Personally, I dislike having to hit "Back" to go to another panel. I don't know if there will be similar feedback during usability testing. So, I believe it's worthy testing this before we remove it. 

From IRC: 
"There could be another way of explaining the mental model: http://cl.ly/image/0h3U0i0T092B  I'm okay with removing it if we find out navigating in between panels is not the user scenario. Given the fact that we have not done any usability study, I think it's a bit too early to just remove it. We should test it first at least."

Comment 4

[Allison Naaktgeboren :ally]

Yuan, what is the time frame or plan for testing it? If we don't have one, we need to get this out of the v1 searches or decide to remove the menu code for v1. Fwiw, this would be really easy to put back in v2 if we were so inclined.

Comment 5

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

Let's leave the menu out for v1.

We will revisit it to see if it still makes sense to have this menu for V2 panels.

Comment 6

[Allison Naaktgeboren :ally]

Attachment: v0 broken tests?

Comment 7

[Allison Naaktgeboren :ally]

Removed menu & associated code, manual testing. Reran changed test, all good.

However, ran the entire mochitest-metro suite & it reported 4 failures, though the failure output in my console contains only failures from browser_history.js ln 109 and browser_urlbar.js which throws an exception from topsitess.js' destructor (_view is null)

Comment 8

[Allison Naaktgeboren :ally]

INFO | runtests.py | Running tests: end.
 2:36.09 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/
base/tests/mochitest/browser_history.js | runTests: Task failed - TypeError: gPa
nelView is null at setup@chrome://mochitests/content/metro/browser/metro/base/te
sts/mochitest/browser_history.js:109
 2:36.09 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/
base/tests/mochitest/browser_history.js | runTests: Task failed - TypeError: gPa
nelView is null at setup@chrome://mochitests/content/metro/browser/metro/base/te
sts/mochitest/browser_history.js:109
 2:36.09 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/
base/tests/mochitest/browser_history.js | runTests: Task failed - TypeError: gPa
nelView is null at setup@chrome://mochitests/content/metro/browser/metro/base/te
sts/mochitest/browser_history.js:109
 2:36.09 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/
base/tests/mochitest/browser_history.js | runTests: Task failed - TypeError: gPa
nelView is null at setup@chrome://mochitests/content/metro/browser/metro/base/te
sts/mochitest/browser_history.js:109
 2:36.09 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/
base/tests/mochitest/browser_urlbar.js | uncaught exception - TypeError: this._v
iew is null at chrome://browser/content/RemoteTabs.js:144

Comment 9

[Allison Naaktgeboren :ally]

Attachment: v1, working tests

hattip to mbrubeck for catching the bug that my vim-grep did not.

Feel free to reassign, but I thought since you've already looked it over, it'd be an easy review for you.

Comment 10

[Allison Naaktgeboren :ally]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2798d3895d4d

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2798d3895d4d

Comment 12

[Samvedana (:Samvedana)]

Can you please provide steps to test this?

Comment 13

[Matt Brubeck (:mbrubeck)]

Most of the panels have also been removed now.  The only place remaining where you can verify this is in the Error Console.  Press control-shift-J to open the Error Console panel.  There should be *no* drop-down menu at the top of the screen near the "Back" button.

Comment 14

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130807030216
Built from http://hg.mozilla.org/mozilla-central/rev/1fb5d14e8348

WFM
Tested on windows 8 using latest nightly  for iteration-11. I didn't see any drop down menu near back button in Error Console.

Comment 15

[Samvedana (:Samvedana)]

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130815030203
Built from http://hg.mozilla.org/mozilla-central/rev/a8daa428ccbc

WFM
Tested on windows 8 using latest nightly for iteration-12. I didn't see any drop down menu near back button in Error Console.