Closed Bug 869643 Opened 12 years ago Closed 12 years ago

change the MONGO variable to MONGOHQ, for easier heroku deployment.

Categories

(Webmaker Graveyard :: Login, defect)

Product:
Webmaker Graveyard
Component:
Login
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: michiel, Assigned: igoryen)

Details

(Whiteboard: c=login)

Attachments

(1 file)

The pull request to my changes to the bug.
53 bytes, text/x-github-pull-request
humph
: review+
michiel
: review+
Details | Review
It'll be a good idea to change the mongodb environment var from MONGO to MONGOHQ, so that we don't need to clone the "MONGOHQ" variable that is set on heroku.
Not change, add. env.get('MONGOHQ') || env.get('MONGO')... etc
even better.
Assignee: nobody → igor.yentaltsev
Status: NEW → ASSIGNED
Comment on attachment 750082 [details] [review] The pull request to my changes to the bug. r+ with a note in the PR for next time. Nice work.
Attachment #750082 - Flags: review?(david.humphrey) → review+
Comment on attachment 750082 [details] [review] The pull request to my changes to the bug. excellent.
Attachment #750082 - Flags: review?(pomax) → review+
Commits pushed to master at https://github.com/mozilla/login.webmaker.org https://github.com/mozilla/login.webmaker.org/commit/9e9caae5accccc51c5910b6d58e0004d290981df [Bug 869643] Fixed environment variable, changed single quotes to double quotes] https://github.com/mozilla/login.webmaker.org/commit/42f21f64f05e518915ab6e08a9956b0742a936d9 Merge pull request #55 from igoryen/bug869643 [Bug 869643] Fixed environment variable, changed single quotes to double...
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: