Closed Bug 869750 Opened 7 years ago Closed 7 years ago

Remove unused variables in HyperTextAccessible.cpp

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

GCC build warnings:
{
accessible/src/generic/HyperTextAccessible.cpp: In member function ‘virtual nsresult mozilla::a11y::HyperTextAccessible::GetTextAtOffset(int32_t, AccessibleTextBoundary, int32_t*, int32_t*, nsAString_internal&)’:

accessible/src/generic/HyperTextAccessible.cpp:1073:21: warning: unused variable ‘wordMovementType’ [-Wunused-variable]

accessible/src/generic/HyperTextAccessible.cpp:1074:8: warning: unused variable ‘moveForwardThenBack’ [-Wunused-variable]
}

These variables' last usages were removed here:
https://hg.mozilla.org/mozilla-central/rev/7a32d12d1dce#l1.133
(note that that cset renamed 'forwardBack' to 'moveForwardThenBack' and also removed its last usages)

Presumably both variables can just be dropped.
Attachment #746715 - Flags: review?(surkov.alexander)
Comment on attachment 746715 [details] [diff] [review]
fix v1: remove unused variables

Review of attachment 746715 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. thanks
Attachment #746715 - Flags: review?(surkov.alexander) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/439bae7c9809
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.