869777 - Work - Navigation bar "choppy" when dismissing while in snapped view

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: App Bar, defect)

Description

[Kamil Jozwiak [:kjozwiak]]

When dismissing the navigation bar in snapped view, you will notice that it will have this "choppy" motion to it before being dismissed correctly after the first time around.

Steps to reproduce the issue:

1) Open Firefox Metro
2) Place Firefox Metro into "Snapped View"
3) Once in "Snapped View", visit any website
4) Once the website has been loaded, slide in the navigation bar (it will be very smooth and as expected)
5) Dismiss the navigation bar (should be smooth the first time around)
6) Repeat Step # 4 & 5 and you will notice that dismissing the navigation bar will be a little "choppy"

Current Behavior:

- When dismissing the navigation bar while in snapped view, you will notice that the dismissal is not smooth and its a bit "choppy"

Expected Behavior:

- Should be dismissed as smooth as sliding the navigation bar into view every single time.

Comment 1

[Allison Naaktgeboren :ally]

looks like the close animation is starting in the wrong spot in snapped.

I see the following: the swipe triggers the animation, which briefly, jumps the nav bar down much lower (as if there were a tabstrip there) and then animates it back through closing the same way it does on desktop.

Comment 2

[Allison Naaktgeboren :ally]

I hypothesize that http://mxr.mozilla.org/mozilla-central/source/browser/metro/theme/browser.css#17 ((-@tray_slide_height@)) is taking the height of the tabstrip into account when it should not be.

Comment 3

[Allison Naaktgeboren :ally]

Attachment: functional, no bounce on start page

I was half right. The other half is a margin that is present on one transition but not the other, and we don't really need hanging about.

The only down side is the bounce on the start snapped page, https://bugzilla.mozilla.org/show_bug.cgi?id=865567#c2, is removed by this fix.

Thanks to :fryn for his help.

Comment 4

[Frank Yan (:fryn)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e9e0810ff90c

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e9e0810ff90c

Comment 6

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" and Tested/Verified that the issue has been resolved. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-05-25-06-25-25-mozilla-central/

- Went through the original test cases in Comment 0 and ensured that it worked without any issues (both in Snapped and Filled View)
- Used the "Windows + Z" shortcut and ensured that it worked without any issues (both in Snapped and Filled View)
- Ensured that there was no issues when attempting to dismiss the "Navigation App Bar" on the awesome screen while in Snapped View

Comment 7

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #9 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-06-25-03-12-38-mozilla-central/

- Went through the original test case from comment 0 without any issues
- Went through the test cases outlined in comment 6 without any issues
- Ensured that the "Tab Bar" at the top was dismissed when going into snapped view from full/filed view
- Ensured that sliding in the "Navigation App Bar" several times on a website worked without any issues