[Video] support mimetype of "video/ogg" for all web activities

RESOLVED FIXED

Status

Firefox OS
Gaia::Video
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dkuo, Assigned: iliu@mozilla.com, ianliu.moz@gmail.com)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:tef+, b2g18 fixed, b2g18-v1.0.1 verified)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
We are able to view/play *.ogg files in video app and they are also known as supported format, we should also enable it when using pick, view and open activities in video app.

Currently this effects email and bluetooth apps because after downloaded or transferred *.ogg files, there is no matched app can open files with 'video/ogg' mimetype.

This will be a simple patch that modifies only the manifest.webapp in video app. Just add "video/ogg" to the filters array of the three activities.
(Reporter)

Updated

5 years ago
Blocks: 851995
Is there any concern that we don't support 'video/ogg' in Video app before?
Since bug 851995 is needed to land in v1-train, the issue should be nominating to leo+ too. We'll need to support opening 'video/ogg' in Video app.
blocking-b2g: --- → leo?
Created attachment 748693 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9713

Pointer to Github pull-request
Comment on attachment 748693 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9713

If we don't have any concern for supporting 'video/ogg' in Video app's 'open' web activity, I think we should fix the issue first.

Dominic,
Could you please help to review my pr? Thanks.
Attachment #748693 - Flags: review?(dkuo)
(Assignee)

Updated

5 years ago
Assignee: dkuo → iliu
(Reporter)

Comment 5

5 years ago
Comment on attachment 748693 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9713

Ian,

As I described in Comment 0, we should try to solve this bug by enabling support for "video/ogg" of pick, view and open activities in video app, but seems like your patch modified open only.

To keep the consistency of all the web activities in video app, I think it's better to also add "video/ogg" to the filters array of pick and view activities. I am cancelling the review request first and after you update your patch, please re-assign to me, thanks.
Attachment #748693 - Flags: review?(dkuo)
Comment on attachment 748693 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9713

Yes, we should let these activites to be sync. Added filetype 'video/ogg' for 'pick' and 'view'. Please help to review again. Thanks.
Attachment #748693 - Flags: review?(dkuo)
(Reporter)

Comment 7

5 years ago
Comment on attachment 748693 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9713

This patch looks good to me now, the issue I mentioned comment 5 is addressed.

r+ on commit: c0213ef9920a247cd61db129018a492a605d0b61
Attachment #748693 - Flags: review?(dkuo) → review+
https://github.com/mozilla-b2g/gaia/commit/4e705ae77b41cad523c520e96e890932a3b8bd88
Since the pr is landed, we can close the issue now. Thanks for Dominic's reviewing effort.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 9

5 years ago
mark tef? because need to uplift patch to v1.01
blocking-b2g: leo? → tef?

Updated

5 years ago
blocking-b2g: tef? → tef+
status-b2g18: --- → affected
status-b2g18-v1.0.1: --- → affected
This bug was partially uplifted.

Uplifted c0213ef9920a247cd61db129018a492a605d0b61 to:
v1-train: 6ee9177708f42edc64b8d99da800ea1e680e1a3e

Commit c0213ef9920a247cd61db129018a492a605d0b61 didn't uplift to branch v1.0.1
status-b2g18: affected → fixed
Ian, can you please uplift to v1.0.1?
Flags: needinfo?(iliu)

Comment 12

5 years ago
Talked with Ian, and he will uplift it now.
Daniel, 
In the fixing patch c0213ef9920a247cd61db129018a492a605d0b61, it will add filetype "video/ogg" for web-activities "pick", "view", "open". 
But we're only supporting web-activities "view" in Video app of v1.0.1.
(https://github.com/mozilla-b2g/gaia/blob/v1.0.1/apps/video/manifest.webapp#L43)

If we really want to uplift the feature to v1.0.1. I would suggest to create a patch for adding filetype "video/ogg" for "view" web-activity only. How do you think? Thank you.
Flags: needinfo?(iliu)
(In reply to Ian Liu [:ianliu] from comment #13)
> Daniel, 
> In the fixing patch c0213ef9920a247cd61db129018a492a605d0b61, it will add
> filetype "video/ogg" for web-activities "pick", "view", "open". 
> But we're only supporting web-activities "view" in Video app of v1.0.1.
> (https://github.com/mozilla-b2g/gaia/blob/v1.0.1/apps/video/manifest.
> webapp#L43)
> 
> If we really want to uplift the feature to v1.0.1. I would suggest to create
> a patch for adding filetype "video/ogg" for "view" web-activity only. How do
> you think? Thank you.

I agree with your suggested approach.
Created attachment 750990 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9844

Pointer to Github pull-request
Comment on attachment 750990 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9844

* Support filetype "video/ogg"  in Video app for "view" web-activity only.

Dominic,
Could you please help to review the pr again? Thanks.
Attachment #750990 - Flags: review?(dkuo)
Comment on attachment 750990 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9844

r-, we can merge the pr directly since it has been reviewed.
Attachment #750990 - Flags: review?(dkuo) → review-

Updated

5 years ago
status-b2g18-v1.0.1: affected → fixed

Comment 19

5 years ago
The user is able to view/play *.ogg files in video app. This bug seems to be fixed.

Inari Build ID: 20130530070213
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/11b55d3ada71
Gaia: ac293ce59acc3bede083fad1b973794fa8bf0253

Unable to verify on Leo V1 train due to https://bugzilla.mozilla.org/show_bug.cgi?id=874615.
status-b2g18-v1.0.1: fixed → verified
You need to log in before you can comment on or make changes to this bug.