869891 - seamonkey should declare itself dpiAware on windows via the .exe manifest

Status: RESOLVED FIXED

(SeaMonkey :: OS Integration, defect)

Description

[Jonathan Kew [:jfkthame]]

+++ This bug was initially created as a clone of Bug #869890 +++

In bug 866365, we removed the call to SetProcessDPIAware from XRE_mainInit(), and instead added the dpiAware element to firefox.exe's manifest. (This is the MS recommended way for an application to declare itself dpi-aware, as per MSDN documentation.)

So to maintain its existing behavior on hi-dpi windows systems, seamonkey should make the same manifest addition. Bug 866365 is likely to be uplifted to mozilla-22, I think, so that's also where the manifest change should be made.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: declare seamonkey.exe as dpi-aware in its manifest

Comment 2

[[e-mail]]

Comment on attachment 746894 [details] [diff] [review]
declare seamonkey.exe as dpi-aware in its manifest

Thanks for porting this!

Comment 3

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/comm-central/rev/e3d49393a3b2

I'm not sure what seamonkey's release schedule is like, or how the version numbers relate to gecko versions, but if there's going to be a release based on gecko 22, you'll probably want to backport this.

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

(In reply to Jonathan Kew (:jfkthame) from comment #3)
> https://hg.mozilla.org/comm-central/rev/e3d49393a3b2
> 
> I'm not sure what seamonkey's release schedule is like

Same as FF's.

> or how the version numbers relate to gecko versions

Current SM versions are 2.<FF/Gecko version - 3>, so Gecko 22 matches SM 2.19.

> but if there's going to be a release based
> on gecko 22, you'll probably want to backport this.

I guess so.

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 746894 [details] [diff] [review]
declare seamonkey.exe as dpi-aware in its manifest

[Approval Request Comment]
See bug 866365 comment 46. As of now, approval-mozilla-aurora is pending.

Comment 6

[Philip Chee]

Comment on attachment 746894 [details] [diff] [review]
declare seamonkey.exe as dpi-aware in its manifest

> See bug 866365 comment 46. As of now, approval-mozilla-aurora is pending.
Conditional a=me based on 866365 landing on mozilla-aurora