Open Bug 869900 Opened 7 years ago Updated 5 years ago

Port | Bug 867118 - Remove browser.__SS_data and use a WeakMap instead | and dependent bugs to SeaMonkey

Categories

(SeaMonkey :: Session Restore, defect)

defect
Not set

Tracking

(Not tracked)

ASSIGNED
seamonkey2.24

People

(Reporter: pppx, Assigned: pppx)

References

(Depends on 1 open bug, Blocks 2 open bugs)

Details

(Keywords: addon-compat, Whiteboard: [leave open])

Attachments

(5 files)

Patch following
Assignee: nobody → pppx
Status: NEW → ASSIGNED
Attachment #746905 - Flags: review?(iann_bugzilla)
Attachment #746911 - Flags: review?(iann_bugzilla)
Depends on: 868026
Depends on: 867097
Comment on attachment 746905 [details] [diff] [review]
Simple copy patch

Looks good so far but you have not included the changes yet to land from bug 867142 and as mentioned in comment 3, there is an older change probably needed too.
f=me for the moment as I want to review and test the new patches once you create them.
Attachment #746905 - Flags: review?(iann_bugzilla) → feedback+
Comment on attachment 746911 [details] [diff] [review]
Simple copy tests

f=me for the moment as I want to review and test the new patches once you create them.
Attachment #746911 - Flags: review?(iann_bugzilla) → feedback+
(In reply to Ian Neal from comment #4)
> Comment on attachment 746905 [details] [diff] [review]
> Simple copy patch
> 
> Looks good so far but you have not included the changes yet to land from bug
> 867142
Yes, I choose to wait till it landed to see if it doesn't cause any regressions

> and as mentioned in comment 3, there is an older change probably
> needed too.
I see, I'll make picking those changes patch and double check other places to see if I don't miss anything
FYI Firefox just backed out a whole bunch of sessionstore patches.
Yes, I saw notification and that why I choose to wait with last patch changes :)
As changes from Bug 698565 now landed, I propose to land part of this bug which already landed in Firefox (that includes already reviewed tests). I have made test build, it works fine
Attachment #791828 - Flags: review?(iann_bugzilla)
Attachment #791828 - Flags: review?(iann_bugzilla) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/42037830dd38
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.24
Sorry, I should set "leave open" in whiteboard, second part of this waiting for landing for Firefox part
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8338012 - Flags: review?(iann_bugzilla)
Attachment #8338699 - Flags: review?(iann_bugzilla)
Depends on: 916390
Attachment #8338699 - Flags: review?(iann_bugzilla) → review+
Attachment #8338012 - Flags: review?(iann_bugzilla) → review+
Keywords: checkin-needed
Whiteboard: [leave open]
Phoenix: Can we close this bug here now?
(In reply to Frank Wein [:mcsmurf] from comment #15)
> Phoenix: Can we close this bug here now?
Flags: needinfo?(pppx)
Two remaining parts are not landed in Firefox yet, I just checked sources and __SS_data is still there, so we are continue to wait. If you think, that closing this bug and opening new for remaining part is better solution, I can do that.
Status: REOPENED → ASSIGNED
Flags: needinfo?(pppx)
Depends on: 1016759
You need to log in before you can comment on or make changes to this bug.