Closed
Bug 869900
Opened 11 years ago
Closed 3 years ago
Port | Bug 867118 - Remove browser.__SS_data and use a WeakMap instead | and dependent bugs to SeaMonkey
Categories
(SeaMonkey :: Session Restore, defect)
SeaMonkey
Session Restore
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.24
People
(Reporter: mz+bugzilla, Assigned: mz+bugzilla)
References
(Depends on 1 open bug, Blocks 2 open bugs)
Details
(Keywords: addon-compat, Whiteboard: [leave open])
Attachments
(5 files)
19.52 KB,
patch
|
iannbugzilla
:
feedback+
|
Details | Diff | Splinter Review |
4.27 KB,
patch
|
iannbugzilla
:
feedback+
|
Details | Diff | Splinter Review |
5.98 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
5.43 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
5.42 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
Patch following
Attachment #746911 -
Flags: review?(iann_bugzilla)
Also see http://hg.mozilla.org/mozilla-central/pushloghtml?changeset=8a62b79f6382
Depends on: 698565
Comment on attachment 746905 [details] [diff] [review] Simple copy patch Looks good so far but you have not included the changes yet to land from bug 867142 and as mentioned in comment 3, there is an older change probably needed too. f=me for the moment as I want to review and test the new patches once you create them.
Attachment #746905 -
Flags: review?(iann_bugzilla) → feedback+
Comment on attachment 746911 [details] [diff] [review] Simple copy tests f=me for the moment as I want to review and test the new patches once you create them.
Attachment #746911 -
Flags: review?(iann_bugzilla) → feedback+
(In reply to Ian Neal from comment #4) > Comment on attachment 746905 [details] [diff] [review] > Simple copy patch > > Looks good so far but you have not included the changes yet to land from bug > 867142 Yes, I choose to wait till it landed to see if it doesn't cause any regressions > and as mentioned in comment 3, there is an older change probably > needed too. I see, I'll make picking those changes patch and double check other places to see if I don't miss anything
Updated•11 years ago
|
Keywords: addon-compat
Comment 7•11 years ago
|
||
FYI Firefox just backed out a whole bunch of sessionstore patches.
Yes, I saw notification and that why I choose to wait with last patch changes :)
As changes from Bug 698565 now landed, I propose to land part of this bug which already landed in Firefox (that includes already reviewed tests). I have made test build, it works fine
Attachment #791828 -
Flags: review?(iann_bugzilla)
Attachment #791828 -
Flags: review?(iann_bugzilla) → review+
Keywords: checkin-needed
Comment 10•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/42037830dd38
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.24
Assignee | ||
Comment 11•11 years ago
|
||
Sorry, I should set "leave open" in whiteboard, second part of this waiting for landing for Firefox part
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 12•11 years ago
|
||
Attachment #8338012 -
Flags: review?(iann_bugzilla)
Assignee | ||
Comment 13•11 years ago
|
||
Attachment #8338699 -
Flags: review?(iann_bugzilla)
Attachment #8338699 -
Flags: review?(iann_bugzilla) → review+
Attachment #8338012 -
Flags: review?(iann_bugzilla) → review+
Keywords: checkin-needed
Whiteboard: [leave open]
Comment 14•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/698afc56b076 https://hg.mozilla.org/comm-central/rev/2f9897b6b7bd
Keywords: checkin-needed
Comment 15•10 years ago
|
||
Phoenix: Can we close this bug here now?
Comment 16•10 years ago
|
||
(In reply to Frank Wein [:mcsmurf] from comment #15) > Phoenix: Can we close this bug here now?
Flags: needinfo?(pppx)
Assignee | ||
Comment 17•10 years ago
|
||
Two remaining parts are not landed in Firefox yet, I just checked sources and __SS_data is still there, so we are continue to wait. If you think, that closing this bug and opening new for remaining part is better solution, I can do that.
Status: REOPENED → ASSIGNED
Flags: needinfo?(pppx)
Assignee | ||
Comment 18•3 years ago
|
||
I've lost track on Firefox part of the changes, and syncing difference here would require a lot of work which is out of scope of this bug, thus closing it as fixed for the landed parts
Status: ASSIGNED → RESOLVED
Closed: 11 years ago → 3 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•