869916 - Cost Control doesn't reset at the beginning of the month

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Kadir Topal [:atopal]]

Even though the app is configured to reset at the first of every month, it keeps showing the data of last month in addition to this month data. This is happening in the app itself, but also on the notification screen.

I'm on an Unagi Phone,

Build Identifier:
20130426070204

Comment 1

[Walter Chen[:ypwalter][:wachen]]

Just wondering if that is because every month = 30 days or if that is due bug?

Comment 2

[Kadir Topal [:atopal]]

Is that a question for me? It's still the case even after 2 weeks in to the new month.

Comment 3

[Walter Chen[:ypwalter][:wachen]]

yes, that was a question for you.
I will try to reproduce it here :P

Build Identifier would be not that useful if you don't specify any other stuffs like code branch(v1train, v101, blah blah blah). Also, if you don't use pvt build, it could be harder for us to reproduce.

Comment 4

[Walter Chen[:ypwalter][:wachen]]

Can you provide more information and screenshot maybe?
I can't reproduce it here.

Comment 5

[Kadir Topal [:atopal]]

Walter, no idea about the code branch, etc. I have an unagi phone and get regular updates, I got that preconfigured. How can I figure out what code branch I am using.

Also, I can send you the screenshot, but it just looks like the normal view, just that it was not reset at the beginning of the month.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

I see this issue after I flashed my Unagi in July and configured the cost control report on July 23rd.

My current build is Boot2Gecko 1.1.0.0-prerelease 20130812041203.

Comment 7

[Leo]

Sometimes this issue can be reproduced by the below STR.

1.Usage->settings->Configure the Reset report(monthly/weekly)->Browse the data/wi-fi and check the data usage->Change the system or device date according to nextReset and check the usage app

2.After changing the device date,the usage app is not reset the data and still shows the old data used.

Comment 8

[Leo]

In costcontrol 
https://github.com/mozilla-b2g/gaia/blob/master/apps/costcontrol/js/config/config_manager.js#L156 we are calling 
asyncStorage.getItem() to get the settings.

Some times https://github.com/mozilla-b2g/gaia/blob/master/shared/js/async_storage.js#L76 req.onsuccess or req.onerror is not getting called.

Comment 9

[Leo]

Found the proper STR and reproduces in LEO.So marking leo+.

Comment 10

[Salvador de la Puente González [:salva]]

Middle air collision, marking as leo? in order to get the leo+ again. Sorry.

Comment 11

[Salvador de la Puente González [:salva]]

Attachment: Synchronizing the asynchronous function `nextReset`

Comment 12

[Salvador de la Puente González [:salva]]

In master, we need the bug 896848 as well to make this to work. AFAIK, it is not the case for v1.1.

Comment 13

[Leo]

Comment on attachment 792241 [details]
Synchronizing the asynchronous function `nextReset`

Tested with Non operator specific SIM card,auto-reset is working fine.

Thanks You Salva.

Comment 14

[Salvador de la Puente González [:salva]]

Same code path is used for authorized SIMs. So merging.

Comment 15

[Salvador de la Puente González [:salva]]

Master: f35d33ac4304c1fc877768648667ebab1622b116

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted f35d33ac4304c1fc877768648667ebab1622b116 to:
v1-train: 52080660c87d4c9a27c05e8e0a1bea698dd2fa34

Comment 17

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 52080660c87d4c9a27c05e8e0a1bea698dd2fa34

Comment 18

[sarsenyev]

The issue no longer reproduces on Leo COM RIL 1.1
The "Cost Control" resets all data usage "Monthly" or "Weekly" on selected day

Environmental  Variables:
Build ID: 20130904041204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/307824edadd7
Gaia: d0a415bbf23e5d01c2b287d9fca708e167cfe70d
Platform Version: 18.1
RIL Version: 01.01.00.019.212
Firmware revision: D300f10a