869966 - Enable Thunderbird building with the Windows 8 SDK

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Mark Banner (:standard8)]

Firefox is already building with the Windows 8 SDK, we should do the same.

Comment 1

[Mark Banner (:standard8)]

Filed bug 869974 to add the MAPI headers to the builders (xref bug 789787 comment 0).

Comment 2

[Mark Banner (:standard8)]

Attachment: Enable building with Windows 8 SDK

This would enable building for the Windows 8 SDK, but I suspect there needs to be an INCLUDE change, once bug 869974 has installed the headers.

Comment 3

[Mark Banner (:standard8)]

Attachment: Enable building with Windows 8 SDK v2

This changes Thunderbird to build with the windows 8 sdk. It won't succeed until bug 869974 has been fixed, but we can get the config changes landed anyway as it'll mean they are ready - as I've already tested on a builder that they are correct.

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 773189 [details] [diff] [review]
Enable building with Windows 8 SDK v2

didn't look too close but (a) this won't harm SeaMonkey, (b) if it worked in staging I'm happy to r+

Comment 5

[Mark Banner (:standard8)]

Landed:

https://hg.mozilla.org/comm-central/rev/684eb19d3cdc

As mentioned earlier, this needs bug 869974 before the windows builders will go green.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 773189 [details] [diff] [review]
Enable building with Windows 8 SDK v2

[Triage Comment]
We need this on aurora as well

https://hg.mozilla.org/releases/comm-aurora/rev/515418cd3276

Comment 7

[Mark Banner (:standard8)]

Windows is now building again.