Enable Thunderbird building with the Windows 8 SDK

RESOLVED FIXED in Thunderbird 25.0

Status

Thunderbird
Build Config
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
Thunderbird 25.0
All
Windows 8

Thunderbird Tracking Flags

(thunderbird24 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Firefox is already building with the Windows 8 SDK, we should do the same.
Filed bug 869974 to add the MAPI headers to the builders (xref bug 789787 comment 0).
Depends on: 869974
Created attachment 746983 [details] [diff] [review]
Enable building with Windows 8 SDK

This would enable building for the Windows 8 SDK, but I suspect there needs to be an INCLUDE change, once bug 869974 has installed the headers.
Created attachment 773189 [details] [diff] [review]
Enable building with Windows 8 SDK v2

This changes Thunderbird to build with the windows 8 sdk. It won't succeed until bug 869974 has been fixed, but we can get the config changes landed anyway as it'll mean they are ready - as I've already tested on a builder that they are correct.
Attachment #746983 - Attachment is obsolete: true
Attachment #773189 - Flags: review?(bugspam.Callek)
Attachment #773189 - Flags: review?(Pidgeot18)
Attachment #773189 - Attachment is patch: true
Comment on attachment 773189 [details] [diff] [review]
Enable building with Windows 8 SDK v2

didn't look too close but (a) this won't harm SeaMonkey, (b) if it worked in staging I'm happy to r+
Attachment #773189 - Flags: review?(bugspam.Callek) → review+
Attachment #773189 - Flags: review?(Pidgeot18)
Landed:

https://hg.mozilla.org/comm-central/rev/684eb19d3cdc

As mentioned earlier, this needs bug 869974 before the windows builders will go green.
Comment on attachment 773189 [details] [diff] [review]
Enable building with Windows 8 SDK v2

[Triage Comment]
We need this on aurora as well

https://hg.mozilla.org/releases/comm-aurora/rev/515418cd3276
Attachment #773189 - Flags: approval-comm-aurora+
Windows is now building again.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-thunderbird24: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 25.0
You need to log in before you can comment on or make changes to this bug.