Last Comment Bug 869966 - Enable Thunderbird building with the Windows 8 SDK
: Enable Thunderbird building with the Windows 8 SDK
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Build Config (show other bugs)
: unspecified
: All Windows 8
: -- normal (vote)
: Thunderbird 25.0
Assigned To: Mark Banner (:standard8)
:
Mentors:
Depends on: 869974
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-08 08:26 PDT by Mark Banner (:standard8)
Modified: 2013-07-10 11:24 PDT (History)
7 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
fixed


Attachments
Enable building with Windows 8 SDK (2.29 KB, patch)
2013-05-08 08:46 PDT, Mark Banner (:standard8)
no flags Details | Diff | Review
Enable building with Windows 8 SDK v2 (8.85 KB, patch)
2013-07-10 03:17 PDT, Mark Banner (:standard8)
bugspam.Callek: review+
standard8: approval‑comm‑aurora+
Details | Diff | Review

Description Mark Banner (:standard8) 2013-05-08 08:26:45 PDT
Firefox is already building with the Windows 8 SDK, we should do the same.
Comment 1 Mark Banner (:standard8) 2013-05-08 08:45:46 PDT
Filed bug 869974 to add the MAPI headers to the builders (xref bug 789787 comment 0).
Comment 2 Mark Banner (:standard8) 2013-05-08 08:46:59 PDT
Created attachment 746983 [details] [diff] [review]
Enable building with Windows 8 SDK

This would enable building for the Windows 8 SDK, but I suspect there needs to be an INCLUDE change, once bug 869974 has installed the headers.
Comment 3 Mark Banner (:standard8) 2013-07-10 03:17:51 PDT
Created attachment 773189 [details] [diff] [review]
Enable building with Windows 8 SDK v2

This changes Thunderbird to build with the windows 8 sdk. It won't succeed until bug 869974 has been fixed, but we can get the config changes landed anyway as it'll mean they are ready - as I've already tested on a builder that they are correct.
Comment 4 Justin Wood (:Callek) 2013-07-10 05:41:43 PDT
Comment on attachment 773189 [details] [diff] [review]
Enable building with Windows 8 SDK v2

didn't look too close but (a) this won't harm SeaMonkey, (b) if it worked in staging I'm happy to r+
Comment 5 Mark Banner (:standard8) 2013-07-10 07:00:29 PDT
Landed:

https://hg.mozilla.org/comm-central/rev/684eb19d3cdc

As mentioned earlier, this needs bug 869974 before the windows builders will go green.
Comment 6 Mark Banner (:standard8) 2013-07-10 09:54:39 PDT
Comment on attachment 773189 [details] [diff] [review]
Enable building with Windows 8 SDK v2

[Triage Comment]
We need this on aurora as well

https://hg.mozilla.org/releases/comm-aurora/rev/515418cd3276
Comment 7 Mark Banner (:standard8) 2013-07-10 11:24:50 PDT
Windows is now building again.

Note You need to log in before you can comment on or make changes to this bug.